From owner-svn-src-head@FreeBSD.ORG Sat May 8 23:01:47 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8A366106566B; Sat, 8 May 2010 23:01:47 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [69.147.83.44]) by mx1.freebsd.org (Postfix) with ESMTP id 7AA458FC13; Sat, 8 May 2010 23:01:47 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o48N1lAK054511; Sat, 8 May 2010 23:01:47 GMT (envelope-from alc@svn.freebsd.org) Received: (from alc@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o48N1l0p054509; Sat, 8 May 2010 23:01:47 GMT (envelope-from alc@svn.freebsd.org) Message-Id: <201005082301.o48N1l0p054509@svn.freebsd.org> From: Alan Cox Date: Sat, 8 May 2010 23:01:47 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r207805 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 May 2010 23:01:47 -0000 Author: alc Date: Sat May 8 23:01:47 2010 New Revision: 207805 URL: http://svn.freebsd.org/changeset/base/207805 Log: Update a comment: It no longer makes sense to talk about the page queues lock here. Modified: head/sys/kern/sys_pipe.c Modified: head/sys/kern/sys_pipe.c ============================================================================== --- head/sys/kern/sys_pipe.c Sat May 8 22:25:37 2010 (r207804) +++ head/sys/kern/sys_pipe.c Sat May 8 23:01:47 2010 (r207805) @@ -767,13 +767,10 @@ pipe_build_write_buffer(wpipe, uio) return (EFAULT); for (i = 0; addr < endaddr; addr += PAGE_SIZE, i++) { /* - * vm_fault_quick() can sleep. Consequently, - * vm_page_lock_queue() and vm_page_unlock_queue() - * should not be performed outside of this loop. + * vm_fault_quick() can sleep. */ race: if (vm_fault_quick((caddr_t)addr, VM_PROT_READ) < 0) { - for (j = 0; j < i; j++) { vm_page_lock(wpipe->pipe_map.ms[j]); vm_page_unhold(wpipe->pipe_map.ms[j]);