Date: Tue, 18 Apr 2017 12:16:16 -0600 From: Ian Lepore <ian@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org>, Joseph Mingrone <jrm@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r438739 - head/editors/emacs-devel Message-ID: <1492539376.96207.31.camel@freebsd.org> In-Reply-To: <9c424b79-d270-6d5f-c625-3de54e721888@FreeBSD.org> References: <201704171817.v3HIHrKH039517@repo.freebsd.org> <9c424b79-d270-6d5f-c625-3de54e721888@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2017-04-18 at 18:30 +0200, Mathieu Arnold wrote: > Le 17/04/2017 à 20:17, Joseph Mingrone a écrit : > > > > Also add MAKE_JOBS_UNSAFE=yes. > > > This bit of the commit message is useless. The fact that you added > MAKE_JOBS_UNSAFE can be seen clearly in the commit diff below. What > cannot be seen and is now lost is why you are adding it. > Does it have problems ordering targets ? Does it try to use a file > before it is generated... ? > People regularly go and try to fix these kind of things. If you do not > explain they why, it is lost, and they have no idea where to begin their > search. The info doesn't have to be lost forever, it's not at all hard to revert the change then re-commit with the proper message. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1492539376.96207.31.camel>