Date: Wed, 26 Jul 2017 07:02:37 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220950] Mk/Scripts/check-stagedir.sh false negatives (with %%OPTIONS%%) Message-ID: <bug-220950-13-aEQaWyZYZV@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220950-13@https.bugs.freebsd.org/bugzilla/> References: <bug-220950-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220950 --- Comment #3 from Gerald Pfeifer <gerald@FreeBSD.org> --- (In reply to Mathieu Arnold from comment #2) > The files should only be included if opt is enabled. No. ;-) What happens here is that these files only were generated due to some patches in the Wine Staging patchset which is enabled via the STAGING option. Over time those patches tend to move from Wine Staging into mainline Wine, at which point they are built by default (without the Staging patchset and hence option STAGING) and need to be included unconditionally. > There are many, many, ports that stage all the files but only package > them if some options are enabled. Hmm, in that case it becomes a little trickier indeed. Good point. > Well, it might be an idea to say something, like "this file is installed > but not packaged" but it must not be either a warning or an error. That would be lovely. Note, this caused real user issues in case of Wine, so is worth addressing (and we don't know which other ports may be affected= ). --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220950-13-aEQaWyZYZV>