From owner-freebsd-ports@FreeBSD.ORG Fri Feb 22 23:46:13 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E0D2EC3B for ; Fri, 22 Feb 2013 23:46:13 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by mx1.freebsd.org (Postfix) with ESMTP id C030924A for ; Fri, 22 Feb 2013 23:46:13 +0000 (UTC) Received: by mail-pa0-f52.google.com with SMTP id fb1so732632pad.25 for ; Fri, 22 Feb 2013 15:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:from:date:message-id:subject:to :content-type; bh=74jaHeqAuSrlsj7xn0zlZVe88mALJdON9rOtWQ2/GsI=; b=d8wLzyDR8dYQHAErRFeNYzdtXjxHQ1bkhWiDggIf4INIh6CVJTteSaRItgq1UqDsbK 6sdgBfkgUJ/kVi5nniZHYUmnUrw7prVVRAbPUwb/dgRV1zFKWOpHPCjvHthjF21YeC/z uOW+bBP1ni0ccYvRwnRl4hYxpHRPNBRIuznGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:from:date:message-id:subject:to :content-type:x-gm-message-state; bh=74jaHeqAuSrlsj7xn0zlZVe88mALJdON9rOtWQ2/GsI=; b=Hu3ua9B5CPPsera/AV8kQUqmepf+zB1YzvPi2JGzxGMpeEaDHXs0vaztTwF7S/V1UE 1g70Kmz8uX2Xm5H0tULHKWvguaBXrIPGEax7v+9e0ibTnH0+LCceejgGsYJA+bNIfFZm sR1+YbChbHfN6GLiTXEH9Aya5GmLzTb+4aoNoh9AzJw2sqdO4fmbHtcf0zafENW7G9Xd 5MIUsH1JB+W+jvHfvrWFo2n3j5QIvvTUFCm70nXWTwOppseoWLVxV4uG8CT762009/+n JMuDRCRbSf7uj3Hv/wkEkglbOEpD3eZJvLrSamt0C+YFwciQYopQrlOq6ahs44dlZC3d RcyA== X-Received: by 10.66.82.226 with SMTP id l2mr6778075pay.64.1361576767802; Fri, 22 Feb 2013 15:46:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.66.245.65 with HTTP; Fri, 22 Feb 2013 15:45:37 -0800 (PST) From: Eitan Adler Date: Fri, 22 Feb 2013 18:45:37 -0500 Message-ID: Subject: CONFIGURE_ENV and CPPFLAGS To: FreeBSD Ports Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQlYWWBjgLFjjBQ8Ei/B7UySBXrzyPgZZy9yVPfdLD8WyJuoagnLIrSlsA8rq6ZSBE5I8TRJ X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2013 23:46:13 -0000 Can you please sanity check the following? commit 687519c34ad3423752268a0a20d079fda9cea8b2 Author: Eitan Adler Date: Fri Feb 22 18:43:30 2013 -0500 Using CONFIGURE_ENV for CPPFLAGS and LDFLAGS is not needed since r282433. PR: docs/174827 Submitted by: Dominique Goncalves diff --git a/en_US.ISO8859-1/books/porters-handbook/book.xml b/en_US.ISO8859-1/books/porters-handbook/book.xml index ef50257..c64cdc7 100644 --- a/en_US.ISO8859-1/books/porters-handbook/book.xml +++ b/en_US.ISO8859-1/books/porters-handbook/book.xml @@ -5726,17 +5726,13 @@ IGNORE= may not be redistributed because of licensing reasons. Please visit +GNU_CONFIGURE= yes Of course, the code can be more compact if there are no more flags to pass to configure: USE_GETTEXT= yes -GNU_CONFIGURE= yes -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ - LDFLAGS="-L${LOCALBASE}/lib" +GNU_CONFIGURE= yes -- Eitan Adler