From owner-svn-ports-head@FreeBSD.ORG Mon Jan 27 10:22:37 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6AEA7918; Mon, 27 Jan 2014 10:22:37 +0000 (UTC) Received: from mail-we0-x22d.google.com (mail-we0-x22d.google.com [IPv6:2a00:1450:400c:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8380016D6; Mon, 27 Jan 2014 10:22:36 +0000 (UTC) Received: by mail-we0-f173.google.com with SMTP id t60so4967528wes.18 for ; Mon, 27 Jan 2014 02:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=hisogNcK70ONvWQ8HYj9zl2CF8WZ3MmBDlSy5Ncx3CA=; b=M2GdHEPagxpgLZu9IP7R4qfYlBtiCXD7JtRiPMeQ1JJagN7Tbk9+f4gsep0iNKxZf+ jzmjQbnkxwWcmGIhmag9ghJtBPFugDoTj81Eu9L8Ydlml1SSjhcaAt1CNlMWk6dZ6rMZ c/nF+R3vuKUztfjcyS6AaBCVpJFpiu/aewqbexrMgx3E693e4KsGTQ/loyj+ykIG2yDC ylocn6Vou6jl9dvMEaQ1hxlSMr+ZI3KG8/ZDVpY0QHc+cUxMCgHUveVo7PJo6oVfzIXb WVr6txy2vGKdzZIlBn/SMx4b9bDuAm0PqGLHcfQPfZ6cNQSv3OHW/UPX9jIHQMLI4C79 Ukhw== X-Received: by 10.194.78.16 with SMTP id x16mr417477wjw.86.1390818154813; Mon, 27 Jan 2014 02:22:34 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id gd5sm28026317wic.0.2014.01.27.02.22.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 27 Jan 2014 02:22:33 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 27 Jan 2014 11:22:31 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r341341 - head/devel/xwpe Message-ID: <20140127102231.GD30300@ithaqua.etoilebsd.net> References: <201401270841.s0R8fjq3007225@svn.freebsd.org> <20140127092855.GA88072@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BI5RvnYi6R4T2M87" Content-Disposition: inline In-Reply-To: <20140127092855.GA88072@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 10:22:37 -0000 --BI5RvnYi6R4T2M87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2014 at 09:28:55AM +0000, Alexey Dokuchaev wrote: > On Mon, Jan 27, 2014 at 08:41:45AM +0000, Baptiste Daroussin wrote: > > New Revision: 341341 > > URL: http://svnweb.freebsd.org/changeset/ports/341341 > > QAT: https://qat.redports.org/buildarchive/r341341/ > >=20 > > +CONFIGURE_ARGS=3D --libdir=3D\$${STAGEDIR}${PREFIX}/share >=20 > Just a heads-up, not implying that you did not check it; but in many cases > it can be wrong: passing ${STAGEDIR} directly to configure script argumen= ts > like this, there is a risk of ${STAGEDIR} getting embedded in the resulti= ng > binaries, which is not what we want. >=20 > To verify if it's OK, one should grep the source code to see if there are > any references to STAGEDIR (DESTDIR) passed via -D... (preprocessor or in > the config.h), and finally, running something like "strings bin/* lib/* | > grep stage" to verify that ${STAGEDIR} does not remain in what would get > installed on users' systems. >=20 > In general, every time you see the need to pass --libdir=3D\$${STAGEDIR} = or > even PREFIX=3D${STAGEDIR}${PREFIX} is an indication that ported software = is > not quite DESTDIR-ready, and should be checked more thoroughly. >=20 stage-qa is checking for that. if you not how this is constructed this is w= ay different from PREFIX=3D${STAGEDIR}${PREFIX} basically the Makefile will en= dup with prefix=3D ${STAGEDIR}/usr/local STAGEDIR is not expanded at all here (like in deskhack.mk) so we are just injecting in the port what it should have nothing more. This particular port is a bit special as the DESTDIR variable is already de= fine it but for something totally different, thus I decided to inject a variable named STAGEDIR instead that is why I defined DESTDIRNAME to STAGEDIR in the makefile. Your remark is valid is still valid for ports doing --prefix=3D${STAGEDIR}${PREFIX} which is often wrong but not for those doing --prefix=3D\$${STAGEDIR}${PREFIX} :) regards, Bapt --BI5RvnYi6R4T2M87 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLmM2cACgkQ8kTtMUmk6ExpKQCfbqDl9J4amS/3tNRVNVNXgCiL I9AAnijihW4a+O+rUQim/jmsZKmcR7Qz =IwyN -----END PGP SIGNATURE----- --BI5RvnYi6R4T2M87--