Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 May 2018 10:27:49 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Koichiro Iwao <meta@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r469188 - head/ports-mgmt/pkg_replace
Message-ID:  <20180506102749.GA58637@FreeBSD.org>
In-Reply-To: <201805061015.w46AF3HQ070595@repo.freebsd.org>
References:  <201805061015.w46AF3HQ070595@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote:
> New Revision: 469188
> URL: https://svnweb.freebsd.org/changeset/ports/469188
> 
> Log:
>   ports-mgmt/pkg_replace: Update to 20180424
>   
>   - Cleanup code
>   - Speed up and strictly check package's dependencies
>   - While here, pet portlint by using pkg-plist instead of PLIST_FILES

Could you explain what did you achieve by moving three-line PLIST_FILES
into pkg-plist?  How can "pet portlint" be a reason for a change while
we generally encourage converting <6-line pkg-plist's into PLIST_FILES?

./danfe

> -
> -PLIST_FILES=	sbin/pkg_replace \
> -		man/man1/pkg_replace.1.gz \
> -		"@sample %%ETCDIR%%/pkg_replace.conf.sample"

Correct PLIST_FILES should read:

PLIST_FILES=	sbin/pkg_replace \
		man/man1/pkg_replace.1.gz \
		@sample\ etc/pkg_replace/pkg_replace.conf.sample

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506102749.GA58637>