From owner-freebsd-usb@FreeBSD.ORG  Fri May  7 07:41:39 2010
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6240B106564A;
	Fri,  7 May 2010 07:41:39 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe07.swip.net [212.247.154.193])
	by mx1.freebsd.org (Postfix) with ESMTP id BAD388FC1A;
	Fri,  7 May 2010 07:41:38 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=6EUBQkwqK50A:10 a=Q9fys5e9bTEA:10
	a=M8b_wTzEtboA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17
	a=6I5d2MoRAAAA:8 a=z2aGyhn3vKXBPhjmJXUA:9
	a=6XT722WisPW-S2q9ZRwHmWw1ZHkA:4 a=PUjeQqilurYA:10
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe07.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 1386811671; Fri, 07 May 2010 09:41:36 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Date: Fri, 7 May 2010 09:38:49 +0200
User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.4; amd64; ; )
References: <201005070349.o473nhSF065849@www.freebsd.org>
In-Reply-To: <201005070349.o473nhSF065849@www.freebsd.org>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA:
	hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR
	Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201005070938.49542.hselasky@c2i.net>
Cc: freebsd-gnats-submit@freebsd.org, Alex Deiter <alex.deiter@gmail.com>
Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse
	support
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 May 2010 07:41:39 -0000

On Friday 07 May 2010 05:49:43 Alex Deiter wrote:
> Alex Deiter
> 

Hi,

The first part of the patch is not correct. The ID byte should be included in 
the buffer or you need to extend the buffer. Note that the kernel version of 
hid_get_data() is different at this point.

The second part of your patch is correct, and indicates a merge glitch, due to 
changing the signedness of the data type some time back.

Can you try the following patch in kernel and user-space and see that it works 
for your BT-mouse and USB-mouse?

http://p4web.freebsd.org/@@177882?ac=10

--HPS