From owner-freebsd-bugs@FreeBSD.ORG  Tue Oct  2 21:50:14 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1CB171065672
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  2 Oct 2012 21:50:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0777C8FC0A
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  2 Oct 2012 21:50:14 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q92LoD13046751
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 2 Oct 2012 21:50:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q92LoDCl046742;
	Tue, 2 Oct 2012 21:50:13 GMT (envelope-from gnats)
Date: Tue, 2 Oct 2012 21:50:13 GMT
Message-Id: <201210022150.q92LoDCl046742@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Erik Cederstrand <erik@cederstrand.dk>
Cc: 
Subject: Re: bin/172289: Check return value of setuid()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Erik Cederstrand <erik@cederstrand.dk>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2012 21:50:14 -0000

The following reply was made to PR bin/172289; it has been noted by GNATS.

From: Erik Cederstrand <erik@cederstrand.dk>
To: bug-followup@FreeBSD.org,
 Eitan Adler <lists@eitanadler.com>
Cc:  
Subject: Re: bin/172289: Check return value of setuid()
Date: Tue, 2 Oct 2012 23:45:58 +0200

 --Apple-Mail=_0AED8E4D-0FE1-4ACE-ADA5-9A2452E0E9E1
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii
 
 ping6 also lack check on return value, btw. Patch attached.
 
 Erik
 
 
 --Apple-Mail=_0AED8E4D-0FE1-4ACE-ADA5-9A2452E0E9E1
 Content-Disposition: attachment;
 	filename=ping6.txt
 Content-Type: text/plain;
 	name="ping6.txt"
 Content-Transfer-Encoding: 7bit
 
 Index: ping6.c
 ===================================================================
 --- ping6.c	(revision 240960)
 +++ ping6.c	(working copy)
 @@ -702,8 +702,10 @@
  	}
  
  	/* revoke root privilege */
 -	seteuid(getuid());
 -	setuid(getuid());
 +	if (seteuid(getuid()) != 0)
 +			err(1, "seteuid() failed");
 +	if (setuid(getuid()) != 0)
 +			err(1, "setuid() failed");
  
  	if ((options & F_FLOOD) && (options & F_INTERVAL))
  		errx(1, "-f and -i incompatible options");
 
 --Apple-Mail=_0AED8E4D-0FE1-4ACE-ADA5-9A2452E0E9E1--