From owner-svn-src-head@freebsd.org Wed Nov 7 16:51:03 2018 Return-Path: <owner-svn-src-head@freebsd.org> Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7141112A260; Wed, 7 Nov 2018 16:51:03 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B678703D0; Wed, 7 Nov 2018 16:51:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id wA7GoxDM001837; Wed, 7 Nov 2018 08:51:00 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id wA7GoxYY001836; Wed, 7 Nov 2018 08:50:59 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> Message-Id: <201811071650.wA7GoxYY001836@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r340220 - head/sys/geom In-Reply-To: <201811071628.wA7GS9RQ081820@repo.freebsd.org> To: Maxim Sobolev <sobomax@freebsd.org> Date: Wed, 7 Nov 2018 08:50:59 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 0B678703D0 X-Spamd-Result: default: False [1.90 / 200.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.24)[0.243,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.02)[country: US(-0.09)]; NEURAL_SPAM_SHORT(0.09)[0.087,0]; MX_GOOD(-0.01)[cached: pdx.rh.CN85.dnsmgr.net]; NEURAL_SPAM_LONG(0.70)[0.701,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/> List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 07 Nov 2018 16:51:03 -0000 [ Charset UTF-8 unsupported, converting... ] > Author: sobomax > Date: Wed Nov 7 16:28:09 2018 > New Revision: 340220 > URL: https://svnweb.freebsd.org/changeset/base/340220 > > Log: > Revert r340187, it breaks EOD (end-of-device) detection logic. Turns out, > i/o into last_sector+N is handled differently for N==1 and N>1 cases to > accomodate that, so some other approach would be needed to fix DIOCGDELETE > ioctl(2). > > Modified: > head/sys/geom/geom_io.c > > Modified: head/sys/geom/geom_io.c > ============================================================================== > --- head/sys/geom/geom_io.c Wed Nov 7 16:22:18 2018 (r340219) > +++ head/sys/geom/geom_io.c Wed Nov 7 16:28:09 2018 (r340220) > @@ -420,8 +420,6 @@ g_io_check(struct bio *bp) > return (EIO); > if (bp->bio_offset > pp->mediasize) > return (EIO); > - if (bp->bio_offset == pp->mediasize && bp->bio_length > 0) > - return (EIO); > > /* Truncate requests to the end of providers media. */ > excess = bp->bio_offset + bp->bio_length; Thanks, I think this is the best thing to do while investigation goes on. -- Rod Grimes rgrimes@freebsd.org