From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar  4 15:46:33 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88C99106566B;
	Tue,  4 Mar 2008 15:46:33 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 46D678FC25;
	Tue,  4 Mar 2008 15:46:33 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m24FhiAJ071514;
	Tue, 4 Mar 2008 08:43:44 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 04 Mar 2008 08:44:12 -0700 (MST)
Message-Id: <20080304.084412.139569940.imp@bsdimp.com>
To: rwatson@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20080304153651.I41184@fledge.watson.org>
References: <20080304151326.J41184@fledge.watson.org>
	<20080304.083350.1661915009.imp@bsdimp.com>
	<20080304153651.I41184@fledge.watson.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: hackers@FreeBSD.org
Subject: Re: Comments on pmake diffs for building on Linux
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2008 15:46:33 -0000

In message: <20080304153651.I41184@fledge.watson.org>
            Robert Watson <rwatson@FreeBSD.org> writes:
: On Tue, 4 Mar 2008, M. Warner Losh wrote:
: 
: > : In most ports of FreeBSD parts to Linux that I've seen, the preferred solution
: > : has to been to bring the entire FreeBSD queue.h with you rather than relying
: > : on the native Linux queue.h.  This is what we do for OpenBSM, for example;
: > : this also helps out when you get to Mac OS X, Solaris, etc, where all the
: > : queue.h's continue to vary in subtle ways.  This depends a fair amount on a
: > : lack of header pollution in the OS's own include files, of course...
: >
: > I was rather hoping for something that could be used without any of that 
: > nonsense...
: 
: Sadly, nonsense seems to be the name of the game in software portability. 
: Here's the broken autoconf garbage I use to pick out adequate queue.h's from 
: inadequate ones:
: 
: # sys/queue.h exists on most systems, but its capabilities vary a great deal.
: # test for LIST_FIRST and TAILQ_FOREACH_SAFE, which appears to not exist in
: # all of them, and are necessary for OpenBSM.
: AC_TRY_LINK([
:          #include <sys/queue.h>
: ], [
: 
:          #ifndef LIST_FIRST
:          #error LIST_FIRST missing
:          #endif
:          #ifndef TAILQ_FOREACH_SAFE
:          #error TAILQ_FOREACH_SAFE
:          #endif
: ], [
: AC_DEFINE(HAVE_FULL_QUEUE_H,, Define if queue.h includes LIST_FIRST)
: ])
: 
: Note that there are at least a couple of mostly stylistic bugs there (could 
: use compile rather than link, definition description is poor, errors are 
: inconsistent). :-)  I found that on both Linux and Mac OS X, the queue.h's 
: didn't have everything I wanted.

Right.  But I'm not going to use autoconf.  It is totally off the
table as far as I'm concerned.

Warner