Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Oct 2015 22:04:22 +0100
From:      =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <jean-sebastien.pedron@dumbbell.fr>
To:        John Baldwin <jhb@freebsd.org>, Hans Petter Selasky <hselasky@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r290135 - in head/sys: compat/linuxkpi/common/include/asm compat/linuxkpi/common/include/linux compat/linuxkpi/common/include/net compat/linuxkpi/common/src conf dev/usb modules/cxgb/iw...
Message-ID:  <563289D6.8070103@dumbbell.fr>
In-Reply-To: <9821922.q97pI4CWiy@ralph.baldwin.cx>
References:  <201510290828.t9T8SdKw015903@repo.freebsd.org> <9821922.q97pI4CWiy@ralph.baldwin.cx>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--f8jxlWgmmoDL5m8fM54r0MDi2tx40xsdq
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 29.10.2015 14:43, John Baldwin wrote:
> On Thursday, October 29, 2015 08:28:39 AM Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Thu Oct 29 08:28:39 2015
>> New Revision: 290135
>> URL: https://svnweb.freebsd.org/changeset/base/290135
>>
>> Log:
>>   Finish process of moving the LinuxKPI module into the default kernel=
 build.
>>  =20
>>   - Move all files related to the LinuxKPI into sys/compat/linuxkpi an=
d
>>     its subfolders.
>>   - Update sys/conf/files and some Makefiles to use new file locations=
=2E
>>   - Added description of COMPAT_LINUXKPI to sys/conf/NOTES which in tu=
rn
>>     adds the LinuxKPI to all LINT builds.
>>   - The LinuxKPI can be added to the kernel by setting the
>>     COMPAT_LINUXKPI option. The OFED kernel option no longer builds th=
e
>>     LinuxKPI into the kernel. This was done to keep the build rules fo=
r
>>     the LinuxKPI in sys/conf/files simple.
>>   - Extend the LinuxKPI module to include support for USB by moving th=
e
>>     Linux USB compat from usb.ko to linuxkpi.ko.
>>   - Bump the FreeBSD_version.
>>   - A universe kernel build has been done.
>>  =20
>>   Reviewed by:	np @ (cxgb and cxgbe related changes only)
>>   Sponsored by:	Mellanox Technologies
>=20
> Humm.  Did you coordinate with dumbbell@ at all?  In his reviews on pha=
bricator
> he had used subdirectories under linuxkpi for different versions Linux =
kernel
> versions.  At the very least it seems like he should have been on the r=
eview
> for this since he is working in the same area doing a very similar thin=
g?

Hi!

Hans kept me in the loop. He did the work because Mellanox was
interested in this change and I have no time currently to work on this
topic.

My patch which allows to have multiple versions in parallel can be
recreated in the future. We decided to put everything in "common" for
now because we have no idea what version of Linux was used to create
this layer. And it probably does not track a specific version at all.

The layout is made so we can add version-specific implementations on top
of the common directory.

--=20
Jean-S=E9bastien P=E9dron


--f8jxlWgmmoDL5m8fM54r0MDi2tx40xsdq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJWMonWXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz
OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTMXlMP/1138Z5+UiXWsAL5z0dZLlH5
yrtdIhGaL5FSg8WHpAvZkXqOsFU5Mrz9iV9s1Ps1rVt61VEVv+QsXF+MrTWPW3x7
0dwBcUxKKbTRNNv7bOxQSjekMNj4dY/62z8sRZdFLaxgdyKSp3ttFFm8q1C/rhoW
Hjk8HV1xixp9W9bBaEoMP9Fe5KksbVtW3+EmGaYFv5erCvn6zPZoQeOR8hbOvO/I
Ysk5qY5slFbFmxH8LuYJWAkwQ/AKgL2bvkBFgQLJhyt/Z1iRY9tXU8lrzfs4mk5v
gB6cg538lgaBQoWcYjJKHaJ5s7KQmxSjW0AILWofWE50Vjm11rjw8G9EhHw4ltth
Qg0CPcRgOxOze1CqwabcLpdFmMZ5XoEpzeA7xKjFEYApxF/DsIiEqvTPLT3NIcUL
hfEBWZs1aH1mE+3+ANVQxgVpZH4ov9RKEJb4dCKt8WvwholygM0F9+pceMd7RtW0
cTwdId7VkvyWkjUl07ikaViKtoFUbbEAUfQzMEWuw/eU9bxOSA7bh87b9GBUu0Y/
an5fCKZGxvQRv6tJLZnQW7OZoOwWyOaOnGs/UY2xYyqxzeHSIWFPlbiUcu1ipR0w
rPfx0zspTiWBSWxQvtzNgaFzxvi2IJ1Ma8Eyew6Nm+UrrT63c/d5wXEIXBIZ2HhM
0NjU/LDnCeHp3mckNr6X
=BH5E
-----END PGP SIGNATURE-----

--f8jxlWgmmoDL5m8fM54r0MDi2tx40xsdq--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?563289D6.8070103>