From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 23 08:00:13 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17B2E106566B for ; Tue, 23 Mar 2010 08:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E227F8FC12 for ; Tue, 23 Mar 2010 08:00:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2N80CpQ028384 for ; Tue, 23 Mar 2010 08:00:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2N80CfT028383; Tue, 23 Mar 2010 08:00:12 GMT (envelope-from gnats) Date: Tue, 23 Mar 2010 08:00:12 GMT Message-Id: <201003230800.o2N80CfT028383@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: bin/139492: pkg_install(1) - overlapping data buffer in call to snprintf X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2010 08:00:13 -0000 The following reply was made to PR bin/139492; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, bruce@cran.org.uk Cc: Subject: Re: bin/139492: pkg_install(1) - overlapping data buffer in call to snprintf Date: Tue, 23 Mar 2010 00:56:51 -0700 --0016367d6878085a7f0482732832 Content-Type: text/plain; charset=ISO-8859-1 How about this instead? This uses c99-style string concatenation to accomplish what's being done with snprintf. Thanks! -Garrett --0016367d6878085a7f0482732832 Content-Type: text/plain; charset=US-ASCII; name="bin.139492.diff.txt" Content-Disposition: attachment; filename="bin.139492.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g74ew5fq0 PT09PSAvL2RlcG90L3Byb2plY3RzL3NvYzIwMDcvZ2Nvb3Blci1wa2dfaW5zdGFsbC1lbmhhbmNl bWVudHMtc2ltcGxpZmllZC91c3Iuc2Jpbi9wa2dfaW5zdGFsbC9saWIvbWF0Y2guYyMxIC0gL3Nj cmF0Y2gvZnJlZWJzZC9wZXJmb3JjZS9wa2dfaW5zdGFsbC1lbmhhbmNlbWVudHMvdXNyLnNiaW4v cGtnX2luc3RhbGwvbGliL21hdGNoLmMgPT09PQpAQCAtMjY3LDcgKzI2Nyw3IEBACiAJICovCiAJ aWYgKGlzZW1wdHlkaXIodG1wKSkKIAkgICAgY29udGludWU7Ci0Jc25wcmludGYodG1wLCBQQVRI X01BWCwgIiVzLyVzIiwgdG1wLCBDT05URU5UU19GTkFNRSk7CisJc3RybmNhdCh0bXAsICIvIiBD T05URU5UU19GTkFNRSwgUEFUSF9NQVgpOwogCWZwID0gZm9wZW4odG1wLCAiciIpOwogCWlmIChm cCA9PSBOVUxMKSB7CiAJICAgIHdhcm54KCJ0aGUgcGFja2FnZSBpbmZvIGZvciBwYWNrYWdlICcl cycgaXMgY29ycnVwdCIsIGluc3RhbGxlZFtpXSk7Cg== --0016367d6878085a7f0482732832--