From owner-cvs-all Fri Jan 28 13:33:56 2000 Delivered-To: cvs-all@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id E47C315D08; Fri, 28 Jan 2000 13:33:09 -0800 (PST) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost) by green.dyndns.org (8.9.3/8.9.3) with ESMTP id QAA41399; Fri, 28 Jan 2000 16:32:13 -0500 (EST) (envelope-from green@FreeBSD.org) X-Authentication-Warning: green.dyndns.org: green owned process doing -bs Date: Fri, 28 Jan 2000 16:32:12 -0500 (EST) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen Makefile.inc In-Reply-To: <200001280714.XAA38397@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thu, 27 Jan 2000, Bruce Evans wrote: > bde 2000/01/27 23:14:54 PST > > Modified files: > lib/libc/gen Makefile.inc > Log: > Install setflags.3 and its link to getflags.3. Am I the only one that's disturbed by the fact that this (nonstandard) function pair has such generic names? Already, it has broken world in two places. It's just not a good idea to have such generic functions in our headers (even if it's more okay for them to be in the libaries...) How about (for instance) strflags() for getflags() and strtoflags() for setflags()? The names right now are extremely ambigous, plus getflags() returns a pointer to a STATIC BUFFER, a very bad and inherently messy, thread-unsafe, etc. etc. thing. Plus, it's not even noted in the manpage. I really have huge beef with these functions... Am I really the only one, and everyone else likes them as they are? > Revision Changes Path > 1.61 +4 -2 src/lib/libc/gen/Makefile.inc -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message