From owner-svn-src-all@freebsd.org Tue Jul 7 18:06:30 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5547D3C41A; Tue, 7 Jul 2015 18:06:30 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 16E3C1C1A; Tue, 7 Jul 2015 18:06:29 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t67I6TO1013648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 7 Jul 2015 11:06:29 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t67I6SYV013647; Tue, 7 Jul 2015 11:06:28 -0700 (PDT) (envelope-from jmg) Date: Tue, 7 Jul 2015 11:06:28 -0700 From: John-Mark Gurney To: Bruce Evans Cc: Ian Lepore , Neel Natu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285217 - head/usr.sbin/bhyve Message-ID: <20150707180627.GD8523@funkthat.com> References: <201507061933.t66JXTtJ050058@repo.freebsd.org> <1436213492.1334.64.camel@freebsd.org> <20150707122407.O1017@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150707122407.O1017@besplex.bde.org> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Tue, 07 Jul 2015 11:06:29 -0700 (PDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 18:06:30 -0000 Bruce Evans wrote this message on Tue, Jul 07, 2015 at 16:11 +1000: > - tty_init_console() doesn't set CLOCAL in the lock state device. So > without fixation, bugs like the one in reset(1) break serial consoles. Here's a patch to fix that: Index: tty.c =================================================================== --- tty.c (revision 284880) +++ tty.c (working copy) @@ -858,6 +858,8 @@ tty_init_console(struct tty *tp, speed_t s) { struct termios *ti = &tp->t_termios_init_in; struct termios *to = &tp->t_termios_init_out; + struct termios *lti = &tp->t_termios_lock_in; + struct termios *lto = &tp->t_termios_lock_out; if (s != 0) { ti->c_ispeed = ti->c_ospeed = s; @@ -866,6 +868,8 @@ tty_init_console(struct tty *tp, speed_t s) ti->c_cflag |= CLOCAL; to->c_cflag |= CLOCAL; + lti->c_cflag |= CLOCAL; + lto->c_cflag |= CLOCAL; } /* I've tested that this fixes the issue (on a machine that doesn't have the bhyve fix yet)... To me this seems a very good way to start it, as it still allows the sysadmin to change the lock device on the console after boot if they so choose... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."