Date: Wed, 26 Sep 2012 19:13:59 GMT From: Devin Teske <dteske@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: bin/172096: sysinstall does not support new DEBUG kernel distribution in 8.x Message-ID: <201209261913.q8QJDxf9077208@red.freebsd.org> Resent-Message-ID: <201209261920.q8QJK4Ct019644@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 172096
>Category: bin
>Synopsis: sysinstall does not support new DEBUG kernel distribution in 8.x
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Sep 26 19:20:04 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Devin Teske
>Release: FreeBSD 8.3-RELEASE-p1 amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scu83a.dev.vicor.com 8.3-RELEASE-p1 FreeBSD 8.3-RELEASE-p1 #2: Tue May 29 18:37:14 PDT 2012 dteske@push830-64.vicor.com:/usr/src/sys/amd64/compile/FIS-amd64 amd64
>Description:
>From Rick Miller via -questions:
I performed a `make release` with FreeBSD 8.3p4 sources that built a secondary kernel (called DEBUG). It ended up in the release inside kernels/ as expected. The install.cfg file includes the line:
dists=base kernels GENERIC SMP DEBUG doc catpages
DEBUG was added to the above along with the new release build. All distributions get installed with the exception of DEBUG. In looking through the sysinstall sources [...] it appears as though the sources need to be modified to support a new DEBUG distribution.
(end quote)
This has been confirmed and the attached patch.txt addresses this, adding the DEBUG kernel distribition to the list of selectable (either via menu or via install.cfg) kernels.
>How-To-Repeat:
Produce installation media under RELENG_8 using release(7). Attempt to craft an automated installer that installs the new DEBUG kernel distribution. Fail (DEBUG kernel distribution not installed as desired because code lacks knowledge of this new dist-set).
>Fix:
See attached patch.txt adding support for this new dist-set.
Patch attached with submission follows:
Index: dist.c
===================================================================
--- dist.c (revision 240968)
+++ dist.c (working copy)
@@ -102,6 +102,7 @@ static Distribution KernelDistTable[] = {
#ifdef WITH_SMP
DTE_TARBALL("SMP", &KernelDists, KERNEL_SMP, "/boot"),
#endif
+ DTE_TARBALL("DEBUG", &KernelDists, KERNEL_DEBUG, "/boot"),
DTE_END,
};
Index: dist.h
===================================================================
--- dist.h (revision 240968)
+++ dist.h (working copy)
@@ -73,6 +73,7 @@
/* Subtypes for KERNEL distribution */
#define DIST_KERNEL_GENERIC 0x00001
#define DIST_KERNEL_SMP 0x00002
+#define DIST_KERNEL_DEBUG 0x00004
#define DIST_KERNEL_ALL 0xFFFFF
/* Canned distribution sets */
Index: menus.c
===================================================================
--- menus.c (revision 240968)
+++ menus.c (working copy)
@@ -1032,6 +1032,8 @@ DMenu MenuKernelDistributions = {
{ " SMP", "GENERIC symmetric multiprocessor kernel configuration",
dmenuFlagCheck, dmenuSetFlag, NULL, &KernelDists, '[', 'X', ']', DIST_KERNEL_SMP },
#endif
+ { " DEBUG", "DEBUG kernel configuration",
+ dmenuFlagCheck, dmenuSetFlag, NULL, &KernelDists, '[', 'X', ']', DIST_KERNEL_DEBUG },
{ NULL } },
};
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209261913.q8QJDxf9077208>