From nobody Mon Mar 20 16:40:40 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PgL886zdMz3yxJQ for ; Mon, 20 Mar 2023 16:40:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PgL885dvkz4Dtm for ; Mon, 20 Mar 2023 16:40:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679330440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8v6s6mj0SXDj7mazZEm7rSULE2UdE9pg/CBzxD3Id3U=; b=uz+4OlGNdfhdv3ySWQIvn/eMIfWyfXDT6HKXGSU3e0RcGELXfHMEX/PQy1fq5utfD6sjJ7 1+rYhLTHCUMe6yelmkzf0ZIr9HX3d/iXSfva6lsYQCUhePkGko6n3l0uO9Boigxq+Fjr9K RBVEt3AUQch3z8yMx5UgHa9W7zjuYXwfq2BM+9ZmKaFAU2cY7bQ+e1cYg2ttiOc7nToGWJ xjVVzAt4xFo79H0txAa16GA0ZsEkkMoCPqfbEO3H6P1NKPmwrfOQJSmr3SQmiS9fZmT8UM 50D4lG0phPbUxk7f5LcrZBk2zPEaqwIMtfueSOuPlO/t+Du8u8xcpNAaNjJ6Ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679330440; a=rsa-sha256; cv=none; b=uL7SgmeSZpaO+0+fg6l1zVI/M0oK8XQDrXYfs646mkLiEYOXsaXWmk0ejbhv6TaTid4HRl ehaXl2HnqFe4mlXk1no2gJajoFU+eAGC0ui/nXYUPOv1P5r2rXLeXFSkz/aEaBp1liKB/j /XPrjCtxVUMcHV6is0Bf5wnPKGubZFLYsh2GZcmeYQd+c0IW8zzP01igSo/jqttrxDk+GT kA41V+npNrqTTDCBkDdYM/QUfIQMH+rTZ2zpcl80xZzpELZ70jm1cYTAn3xQDmjm5vZAF4 xTeYmzxVbIJpgzvahswqFPdfE+KEnfPEPpOL5qR65wIOoRtSHn2Teo+vHVYA4Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PgL884jLLzcl2 for ; Mon, 20 Mar 2023 16:40:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32KGeeXJ059732 for ; Mon, 20 Mar 2023 16:40:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32KGee4B059731 for net@FreeBSD.org; Mon, 20 Mar 2023 16:40:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Mon, 20 Mar 2023 16:40:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #96 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D844ad2828a35c434b893af4274b1f6c50= 332dd70 commit 844ad2828a35c434b893af4274b1f6c50332dd70 Author: Kristof Provost AuthorDate: 2023-03-20 13:26:33 +0000 Commit: Kristof Provost CommitDate: 2023-03-20 15:39:14 +0000 pfsync: add missing unlock in pfsync_defer_tmo() The callout for pfsync_defer_tmo() is created with CALLOUT_RETURNUNLOCKED, because while the callout framework takes care of taking the lock we want to run a few operations outside of the lock, so we unlock ourselves. However, if `sc->sc_sync_if =3D=3D NULL` we return without releasing the lock, and leak the lock, causing later deadlocks. Ensure we always release the bucket lock when we exit pfsync_defer_tmo() PR: 268246 MFC after: 1 week Sponsored by: Rubicon Communications, LLC (Netgate) sys/netpfil/pf/if_pfsync.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=