From owner-freebsd-arch@FreeBSD.ORG Sat May 13 13:30:26 2006 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C419A16A40A; Sat, 13 May 2006 13:30:26 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx0.rink.nu (morion.rink.nu [80.112.228.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50EA843D46; Sat, 13 May 2006 13:30:25 +0000 (GMT) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx0.rink.nu (Postfix) with ESMTP id E06BC64; Sat, 13 May 2006 15:29:49 +0200 (CEST) Received: from mx0.rink.nu ([127.0.0.1]) by localhost (morion.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89357-01; Sat, 13 May 2006 15:29:19 +0200 (CEST) Received: by mx0.rink.nu (Postfix, from userid 1678) id BE0A162; Sat, 13 May 2006 15:29:17 +0200 (CEST) Date: Sat, 13 May 2006 15:29:17 +0200 From: Rink Springer To: Tom Rhodes Message-ID: <20060513132917.GC79186@rink.nu> References: <20060328070332.GA53789@rink.nu> <20060328205625.658396e8.trhodes@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline In-Reply-To: <20060328205625.658396e8.trhodes@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: amavisd-new at rink.nu Cc: arch@FreeBSD.org Subject: Re: [RFC] Syslogd service patch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 May 2006 13:30:36 -0000 --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Tom, Sorry for the extremely long delay (I was moving...). A new patch can be found at http://rink.nu/tmp/syslogd2.diff. As per your comments: > Need a new line here, perhaps reword to avoid starting a > sentence with lower cased words. The entire sentence has been reworded. > ?? *cp++ =3D 0? >=20 > Perhaps I'm just lost. This is used to null-terminate the host name; this avoids using the 'host:service' pair as the hostname. >=20 > + > (void)strlcpy(f->f_un.f_forw.f_hname, ++p, > sizeof(f->f_un.f_forw.f_hname)); > + >=20 > Is this new line on purpose? No; I've removed it. Any comments? --=20 Rink P.W. Springer - http://rink.nu "Richter: Tribute? You steal men's souls, and make them your slaves! Dracula: Perhaps the same could be said of all religions." - Castlevania: Symphony of the Night --zhXaljGHf11kAtnf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFEZd8tb3O60uztv/8RAn2NAJ9CQM0Q33zpTHWhGFn8COvd2FK+qgCfYxpq B0ax4MR2MVBQrcao0TXLnDY= =1Dg9 -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf--