Date: Sun, 12 Jan 2025 20:56:23 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Larry Rosenman <ler@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 0654456e0611 - main - sysutils/lsof: fix breakage after 3a0cdb2675e6 Message-ID: <20250113045623.20AFF149@slippy.cwsent.com> In-Reply-To: <202501112057.50BKvD38009217@gitrepo.freebsd.org> References: <202501112057.50BKvD38009217@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <202501112057.50BKvD38009217@gitrepo.freebsd.org>, Larry Rosenman wr ites: > The branch main has been updated by ler: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=0654456e061181e74fd0eb06f9b966 > a4e759769d > > commit 0654456e061181e74fd0eb06f9b966a4e759769d > Author: Larry Rosenman <ler@FreeBSD.org> > AuthorDate: 2025-01-11 20:51:00 +0000 > Commit: Larry Rosenman <ler@FreeBSD.org> > CommitDate: 2025-01-11 20:51:00 +0000 > > sysutils/lsof: fix breakage after 3a0cdb2675e6 > > - put /usr/src first. > --- > sysutils/lsof/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sysutils/lsof/Makefile b/sysutils/lsof/Makefile > index f65273c5c932..a10d7db4320a 100644 > --- a/sysutils/lsof/Makefile > +++ b/sysutils/lsof/Makefile > @@ -3,6 +3,7 @@ > > PORTNAME= lsof > DISTVERSION= 4.99.4 > +PORTREVISION= 1 > PORTEPOCH= 8 > CATEGORIES= sysutils > > @@ -40,7 +41,7 @@ BOOKE_CFLAGS= -DBOOKE > CONFIGURE_SCRIPT= Configure > CONFIGURE_ARGS= -n freebsd > CONFIGURE_ENV= FREEBSD_SYS="${SRC_BASE}/sys" \ > - LSOF_CC="${CC}" > + LSOF_CC="${CC} -idirafter /usr/src" This is wrong. If /usr/src is updated, i.e. git pull, but not installed, i.e. installworld, header files and libraries may be mismatched. Note: The follow-on 1ec769ae9a64 perpetuates this wrong-ness. > BUILD_DEPENDS= ${LOCALBASE}/bin/bash:shells/bash > > # GCC needs -lzfs -lzpool for reasons unknown. If someone can > -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20250113045623.20AFF149>