From owner-freebsd-bugs@FreeBSD.ORG Thu Mar 29 09:00:23 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C8AAE106566B for ; Thu, 29 Mar 2012 09:00:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8066F8FC12 for ; Thu, 29 Mar 2012 09:00:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2T90NwG029765 for ; Thu, 29 Mar 2012 09:00:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2T90NoW029754; Thu, 29 Mar 2012 09:00:23 GMT (envelope-from gnats) Resent-Date: Thu, 29 Mar 2012 09:00:23 GMT Resent-Message-Id: <201203290900.q2T90NoW029754@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Roy Marples Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E5C8106566C for ; Thu, 29 Mar 2012 08:53:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 6A1708FC1A for ; Thu, 29 Mar 2012 08:53:55 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2T8rsM2062469 for ; Thu, 29 Mar 2012 08:53:54 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q2T8rsQc062455; Thu, 29 Mar 2012 08:53:54 GMT (envelope-from nobody) Message-Id: <201203290853.q2T8rsQc062455@red.freebsd.org> Date: Thu, 29 Mar 2012 08:53:54 GMT From: Roy Marples To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/166483: if_nametoindex sends un-initialized bytes to ioctl X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 09:00:23 -0000 >Number: 166483 >Category: bin >Synopsis: if_nametoindex sends un-initialized bytes to ioctl >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 29 09:00:22 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Roy Marples >Release: 7.1 >Organization: >Environment: [roy@uberlaptop /usr/home/roy]$ uname -a FreeBSD uberlaptop 7.1-RELEASE-p2 FreeBSD 7.1-RELEASE-p2 #3: Mon Feb 9 17:12:55 GMT 2009 root@uberlaptop:/usr/obj/usr/src/sys/GENERIC i386 >Description: if_nametoindex(3) sends un-initialized bytes to ioctl I found this when I was fixing BSD specific memory issues with dhcpcd. With the below patch to libc applied, dhcpcd-5.5.6 runs flawlessly without any errors reported by Valgrind. >How-To-Repeat: >Fix: Patch attached with submission follows: --- if_nametoindex.c.orig 2012-03-28 20:14:38.000000000 +0100 +++ if_nametoindex.c 2012-03-28 20:15:20.000000000 +0100 @@ -70,6 +70,7 @@ s = _socket(AF_INET, SOCK_DGRAM, 0); if (s != -1) { + memset(&ifr, 0, sizeof(ifr)); strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name)); if (_ioctl(s, SIOCGIFINDEX, &ifr) != -1) { _close(s); >Release-Note: >Audit-Trail: >Unformatted: