From owner-cvs-ports@FreeBSD.ORG Sat Dec 24 18:35:04 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 318E5106566B; Sat, 24 Dec 2011 18:35:04 +0000 (UTC) (envelope-from skv@protey.ru) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 03FA58FC08; Sat, 24 Dec 2011 18:35:00 +0000 (UTC) Received: by eaaf13 with SMTP id f13so13004886eaa.13 for ; Sat, 24 Dec 2011 10:34:59 -0800 (PST) Received: by 10.213.28.207 with SMTP id n15mr181597ebc.92.1324750082971; Sat, 24 Dec 2011 10:08:02 -0800 (PST) Received: from [192.168.0.5] (95-26-97-96.broadband.corbina.ru. [95.26.97.96]) by mx.google.com with ESMTPS id u53sm18210930eeu.6.2011.12.24.10.08.00 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 24 Dec 2011 10:08:01 -0800 (PST) Sender: Sergey Skvortsov Message-ID: <4EF614FA.3000003@FreeBSD.org> Date: Sat, 24 Dec 2011 22:07:54 +0400 From: Sergey Skvortsov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Michael Scheidell References: <201112081102.pB8B24Ok055597@repoman.freebsd.org> In-Reply-To: <201112081102.pB8B24Ok055597@repoman.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, komarov@valerka.net, =?UTF-8?B?bg==?= , cvs-ports@FreeBSD.org, =?UTF-8?B?R8OhYm9yIEvDtnZlc2TDoQ==?= Subject: Re: cvs commit: ports/devel/thrift Makefile distinfo pkg-plist ports/devel/thrift/files patch-configure.ac patch-lib__c_glib__src__transport__thrift_framed_transport.h patch-lib__c_glib__src__transport__thrift_socket.h patch-lib__cpp__src__server__TNonblockingServer.h X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 18:35:04 -0000 On 08.12.2011 15:02, Michael Scheidell wrote: > scheidell 2011-12-08 11:02:04 UTC > > FreeBSD ports repository > > Modified files: > devel/thrift Makefile distinfo pkg-plist > Added files: > devel/thrift/files > patch-lib__c_glib__src__transport__thrift_framed_transport.h > patch-lib__c_glib__src__transport__thrift_socket.h > patch-lib__cpp__src__server__TNonblockingServer.h > Removed files: > devel/thrift/files patch-configure.ac > Log: > -Update to 0.7.0 [1] > -Fix Build C++ Library [1] > -pet portlint > > PR: ports/159902 [1] > Submitted by: Valery Komarov [1] > Approved by: skv (maintainer timeout, 100 days), gabor (mentor) > Feature safe: yes Hi. 1. Before committing, please check that included in PR software version is fresh enough: - 0.8.0 was released on 2011-11-30: http://archive.apache.org/dist/thrift/0.8.0/ - your commit was on 2011-12-08. 2. Thrift port is critical enough because many other ports depend on it: find /usr/ports/ -name Makefile -exec grep -w -l thrift {} \+ So you must (not "should") test all depended ports in Tinderbox before committing somewhat in "devel/thrift". You obviously did not test even "devel/*-[Tt]hrift*" ports. 3. Please run "portlint -C" before commit. Right now we can see fatal error: FATAL: /usr/home/godegisel/ports/devel/thrift/pkg-plist: [95]: installing pkg-config files into lib/pkgconfig. All pkg-config files must be installed into libdata/pkgconfig for them to be found by pkg-config. 4. Because you took maintainership on "devel/thrift" from me, please also take "devel/ruby-thrift" and "devel/p5-Thrift". Thanks in advance. -- Sergey Skvortsov mailto: skv@FreeBSD.org