From owner-svn-ports-all@freebsd.org Tue Mar 21 17:57:55 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 913EAD16BD1; Tue, 21 Mar 2017 17:57:55 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7374EC62; Tue, 21 Mar 2017 17:57:54 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v2LHvrOU063098 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Mar 2017 10:57:54 -0700 (PDT) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v2LHvrr3063097; Tue, 21 Mar 2017 10:57:53 -0700 (PDT) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 21 Mar 2017 10:57:53 -0700 From: Gleb Smirnoff To: Gerald Pfeifer Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436576 - in head/emulators/wine-devel: . files Message-ID: <20170321175753.GV23308@FreeBSD.org> References: <201703210858.v2L8w0Zr014870@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 17:57:55 -0000 Gerald, On Tue, Mar 21, 2017 at 06:43:01PM +0100, Gerald Pfeifer wrote: G> On Tue, 21 Mar 2017, Gleb Smirnoff wrote: G> > Log: G> > Make it compilable on FreeBSD 12 after struct inpcb and struct tcpcb G> > were stopped being exported. G> > Added: G> > head/emulators/wine-devel/files/patch-dlls_iphlpapi_ipstats.c (contents, props changed) G> G> thanks for creating a fix for this and sharing it. G> G> > +PORTREVISION= 1 G> G> This actually isn't necessary and triggers a needless rebuild for G> users on older versions of FreeBSD than that. G> G> (When the build is broken under some circumstances, but not others, G> simply fixing it is sufficient.) G> G> This is why (gentle hint) it actually does make sense to working G> with the maintainer of a port instead of just committing a fix. :-) But without the bump I can't enforce rebuild for FreeBSD 12 users, can I? G> > Added: head/emulators/wine-devel/files/patch-dlls_iphlpapi_ipstats.c G> > ============================================================================== G> G> Have you submitted this upstream as well? We should minimize local G> patches like this, not the least since some people (and my nightly G> automated tester, for example) also build from upstream sources. G> G> And it adds maintenance overhead over time. G> G> G> If you have not submitted it yet, G> https://wiki.winehq.org/Submitting_Patches G> has good information (if a bit much I'll admit) and I'll be happy G> to help. G> G> At a minimum, if you don't want to follow the regular process, G> sending it to wine-patches@winehq.com copying me would be good. Once I'm done with settling dust after this change, I am going to go through all my commits and try to upstream all of them. -- Totus tuus, Glebius.