Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Oct 2012 05:28:14 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Michael Tuexen <tuexen@fh-muenster.de>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Xin LI <delphij@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au>
Subject:   Re: svn commit: r241916 - in head/sys: netinet netinet6
Message-ID:  <20121024052525.T4723@besplex.bde.org>
In-Reply-To: <FD4A4199-80DB-4D24-8468-29CA121DD1D9@fh-muenster.de>
References:  <201210222149.q9MLnvrt014543@svn.freebsd.org> <20121023142219.K1008@besplex.bde.org> <FD4A4199-80DB-4D24-8468-29CA121DD1D9@fh-muenster.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 23 Oct 2012, Michael Tuexen wrote:

> On Oct 23, 2012, at 6:23 AM, Bruce Evans wrote:
>
>> On Mon, 22 Oct 2012, Xin LI wrote:
>>
>>> Log:
>>> Remove __P.
>>
>> This was a chance to remove style bugs in the prototypes.  At least it
>> didn't create so many new ones, unlike the original __P axing.  It
>> still enlarged about a hundred by changing from Gnu style continuation
>> to Gnu style continuation indentation with an off-by-5 error.
>
> please note that the SCTP code in the FreeBSD sources is generated
> via an export script from a codebase which runs on multiple platforms.
> The script tries to follow FreeBSDs guidelines, but is far from being
> perfect.

The export script might not like manual editing of its output.

Portability might require __P(()), and then removing it cleaning requires
a complicated script.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121024052525.T4723>