From owner-svn-src-head@FreeBSD.ORG  Tue Oct 23 18:28:39 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C3DEAAF8;
 Tue, 23 Oct 2012 18:28:39 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail35.syd.optusnet.com.au (mail35.syd.optusnet.com.au
 [211.29.133.51])
 by mx1.freebsd.org (Postfix) with ESMTP id 3B40E8FC0C;
 Tue, 23 Oct 2012 18:28:39 +0000 (UTC)
Received: from c122-106-175-26.carlnfd1.nsw.optusnet.com.au
 (c122-106-175-26.carlnfd1.nsw.optusnet.com.au [122.106.175.26])
 by mail35.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q9NISEhD018400
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Wed, 24 Oct 2012 05:28:21 +1100
Date: Wed, 24 Oct 2012 05:28:14 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Michael Tuexen <tuexen@fh-muenster.de>
Subject: Re: svn commit: r241916 - in head/sys: netinet netinet6
In-Reply-To: <FD4A4199-80DB-4D24-8468-29CA121DD1D9@fh-muenster.de>
Message-ID: <20121024052525.T4723@besplex.bde.org>
References: <201210222149.q9MLnvrt014543@svn.freebsd.org>
 <20121023142219.K1008@besplex.bde.org>
 <FD4A4199-80DB-4D24-8468-29CA121DD1D9@fh-muenster.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org, Xin LI <delphij@FreeBSD.org>,
 Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 18:28:40 -0000

On Tue, 23 Oct 2012, Michael Tuexen wrote:

> On Oct 23, 2012, at 6:23 AM, Bruce Evans wrote:
>
>> On Mon, 22 Oct 2012, Xin LI wrote:
>>
>>> Log:
>>> Remove __P.
>>
>> This was a chance to remove style bugs in the prototypes.  At least it
>> didn't create so many new ones, unlike the original __P axing.  It
>> still enlarged about a hundred by changing from Gnu style continuation
>> to Gnu style continuation indentation with an off-by-5 error.
>
> please note that the SCTP code in the FreeBSD sources is generated
> via an export script from a codebase which runs on multiple platforms.
> The script tries to follow FreeBSDs guidelines, but is far from being
> perfect.

The export script might not like manual editing of its output.

Portability might require __P(()), and then removing it cleaning requires
a complicated script.

Bruce