From owner-freebsd-ports-bugs@FreeBSD.ORG Tue May 4 09:40:03 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BB8041065675 for ; Tue, 4 May 2010 09:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 7FCAA8FC24 for ; Tue, 4 May 2010 09:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o449e39K078796 for ; Tue, 4 May 2010 09:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o449e3Lm078795; Tue, 4 May 2010 09:40:03 GMT (envelope-from gnats) Resent-Date: Tue, 4 May 2010 09:40:03 GMT Resent-Message-Id: <201005040940.o449e3Lm078795@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DA6391065672 for ; Tue, 4 May 2010 09:31:54 +0000 (UTC) (envelope-from dan@obluda.cz) Received: from master7.ms.mff.cuni.cz (master7.ms.mff.cuni.cz [195.113.20.22]) by mx1.freebsd.org (Postfix) with ESMTP id 770E18FC1F for ; Tue, 4 May 2010 09:31:53 +0000 (UTC) Received: from master7.ms.mff.cuni.cz (localhost [127.0.0.1]) by master7.ms.mff.cuni.cz (8.14.3/8.14.3) with ESMTP id o449VrSk009715 for ; Tue, 4 May 2010 11:31:53 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by master7.ms.mff.cuni.cz (8.14.3/8.14.3/Submit) id o449VqgS009714; Tue, 4 May 2010 11:31:53 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <201005040931.o449VqgS009714@master7.ms.mff.cuni.cz> Date: Tue, 4 May 2010 11:31:53 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/146294: [ PATCH ] mail/cclient doesn't honor WITH_OPENSSL_PORT=yes correctly X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2010 09:40:03 -0000 >Number: 146294 >Category: ports >Synopsis: [ PATCH ] mail/cclient doesn't honor WITH_OPENSSL_PORT=yes correctly >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 04 09:40:03 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD i386 >Organization: Obludarium >Environment: System: FreeBSD i386 mail/cclient/Makefile,v 1.44 2009/11/18 22:39:52 >Description: The port improperly honor WITH_OPENSSL_PORT=yes In link against libraries from port, but use include files from base during compilation The resulting product is unstable and coredumps often >How-To-Repeat: 1. set WITH_OPENSSL_PORT=yes 2. rename /usr/include/openssl and /usr/bin/openssl to something else Try to compile. >Fix: --- Makefile.orig 2010-02-03 12:28:21.000000000 +0100 +++ Makefile 2010-05-04 11:26:24.000000000 +0200 @@ -26,12 +26,10 @@ MAKE_JOBS_UNSAFE= yes -.include - USE_LDCONFIG= yes ALL_TARGET= bsf .if defined(WITHOUT_SSL) -MAKE_ARGS+= SSLTYPE=none SSLDIR=${OPENSSLBASE} +MAKE_ARGS+= SSLTYPE=none .else USE_OPENSSL= yes .if defined(WITH_SSL_AND_PLAINTEXT) @@ -40,6 +38,7 @@ MAKE_ARGS+= SSLTYPE=unix.nopwd .endif .endif +MAKE_ARGS+= SSLDIR=${OPENSSLBASE} SSLINCLUDE=${OPENSSLINC} SSLLIB=${OPENSSLLIB} WRKSRC= ${WRKDIR}/${DISTNAME} @@ -54,7 +53,10 @@ @${REINPLACE_CMD} -e "s|/usr/local|${PREFIX}|g" ${WRKSRC}/${file} .endfor @${REINPLACE_CMD} -e "s:/etc/ssl/certs:${PREFIX}/certs:g; \ - s:/etc/ssl/private:${PREFIX}/certs:g" ${WRKSRC}/Makefile + s:/etc/ssl/private:${PREFIX}/certs:g; \ + s:SSLINCLUDE=[^ ]*:SSLINCLUDE=\\$$\\(SSLINCLUDE\\):; \ + s:SSLLIB=[^ ]*:SSLLIB=\\$$\\(SSLLIB\\):; \ + " ${WRKSRC}/Makefile .if !defined(WITHOUT_IPV6) @${REINPLACE_CMD} -e "s|^IP=4|IP=6|" ${WRKSRC}/Makefile \ ${WRKSRC}/src/osdep/unix/Makefile @@ -106,4 +108,4 @@ @${ECHO} "================================================================================" .endif -.include +.include >Release-Note: >Audit-Trail: >Unformatted: