From owner-p4-projects@FreeBSD.ORG Wed May 27 19:56:04 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F24AC106581C; Wed, 27 May 2009 19:56:03 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1684106575F for ; Wed, 27 May 2009 19:56:03 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe08.swip.net [212.247.154.225]) by mx1.freebsd.org (Postfix) with ESMTP id 3318F8FC14 for ; Wed, 27 May 2009 19:56:01 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=jAwUbfdTuR0A:10 a=8kQB0OdkAAAA:8 a=vEyOsxuhjF6HV9CpVaoA:9 a=-qi3r90pPu3Q6fVe8ZuGJRCEJ6oA:4 a=9aOQ2cSd83gA:10 a=6H5-1_0l2zB8xAjc:21 a=kC3q_QdDwJB-WdPr:21 Received: from [62.113.132.61] (account mc467741@c2i.net HELO [10.37.1.92]) by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.13) with ESMTPA id 1248525299; Wed, 27 May 2009 21:56:00 +0200 From: Hans Petter Selasky To: Sylvestre Gallon Date: Wed, 27 May 2009 22:00:04 +0200 User-Agent: KMail/1.9.7 References: <200905271656.n4RGuEgK056279@repoman.freebsd.org> <200905272129.39606.hselasky@c2i.net> <164b4c9c0905271239w21e72ad2r14014dfdd11099c9@mail.gmail.com> In-Reply-To: <164b4c9c0905271239w21e72ad2r14014dfdd11099c9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200905272200.04784.hselasky@c2i.net> Cc: Perforce Change Reviews Subject: Re: PERFORCE change 162889 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2009 19:56:05 -0000 On Wednesday 27 May 2009, Sylvestre Gallon wrote: > On Wed, May 27, 2009 at 7:29 PM, Hans Petter Selasky =20 wrote: > > On Wednesday 27 May 2009, Sylvestre Gallon wrote: > >> +=A0=A0=A0=A0=A0=A0=A0case LIBUSB_TRANSFER_TYPE_ISOCHRONOUS: > >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0/* what means frindex ? = */ > >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0libusb20_tr_setup_isoc(u= sb20_xfer, xfer->buffer, > >> xfer->length, 0); > > > > Unlike in the kernel you need to specify the buffer+length pair for all > > ISOCHRONOUS frames up to and including "max_frames-1". > > > > In you code you have only setup one frame [index 0] . > > ok, > > if I understand fr_index arguments in libusb20_tr_setup_isoc refers to > the number of isochronous packets ? It is the index of the isochronous packet. You setup a transfer of multiple= =20 isochronous packets at a time, and typically initialise like this: for (i =3D 0; i !=3D MAX_FRAMES; i++) { libusb20_tr_setup_isoc(usb20_xfer, buf, MAX_LEN, i); buf +=3D MAX_LEN; } With regard to libusb 1.0 you need to check that structure array extending = the=20 USB transfer for length and pointer information I think. !NOTE! The userland libusb allowes a per-packet pointer. In the kernel the= =20 packets must be back to back, and only one buffer pointer is used. =2D-HPS