From nobody Fri Dec 19 16:45:54 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dXthR3D5Kz6M1h5 for ; Fri, 19 Dec 2025 16:45:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dXthL2PQMz3pfZ for ; Fri, 19 Dec 2025 16:45:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766162754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cK6Y8eyzvXWI4/Q2JmcZYRwzCZ5SbH+8K7YQbYnkiHM=; b=cTuPDcHm9ZdvzI+XwGoEfhy6mvUZ2WgR0+I2oEQUeOVbWpCn+VZXWcyuq4/Zf7lcxUbSS7 ut9z1iVunXfvby9Xa6WcSa02frTNIS8dyc1lFX6+HcP2E2nQa7tmfEUjaD/xkgHWSPuuyS cMhbsQeXUHlTHOGo8AP3r7sI565OmKOggVBzOO52OBKMKwnZaCvXpJZgmW6XJpXsszsZ2M W48xHzWH+pEiSG3AFUcai2puudtdWGAfGFyi6qv5q5dx+4iSCIITJ6gFmVzWnFSBMxpkRh q9PdsBi2ro8XoGedWof7XdhexFHzvClnFGD8iUzz/eX3Cr6suxiaFSbI3tdPhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766162754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cK6Y8eyzvXWI4/Q2JmcZYRwzCZ5SbH+8K7YQbYnkiHM=; b=IELUqAa+Xxk2C/5Ej2os+zwNVLE8hUflTzz3iU2/bZaZCGXN3kf8avqakqogXx4crdZOzV I74MiIzklBHyYA+YAksdT9RjdHERHxg5ANvRF5OXB+dzUF+lbwIcRKdM5a74WlRYqyhRST hA4xlSyI+Qp8foId+ENOriDszqGY1Z1E9DaHbOUS1nZmqYBCB+BBGD+tO+u0hFYxCW3NMC Eqt1RoQE9QiYpdd1ZMVRXK9o/FxNY5CuDveP9OKu6r/tLZPqIWtrFobHtNZUfP1ydJ4AMf XUtGEiEE82H8kiNbzf54T+UNj/G+1nIIt3yzsDQLYzbN926pO/26jT/KTl/1Pg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766162754; a=rsa-sha256; cv=none; b=vPmosmCqivQzUBCGZNcn3AtwGvrMhSgx/ZpcX+BH2GHj+TrzxWxAnx02JlhX3Ds7H0xIdC kV6WDAlu2aZpVi9NTWMjfW86OFIoBNZ5C1uWp/lHZnndc/4XuWr5Me+7YzQVJSoQuRHWxT fkKJcok5JNJzKra9Ph9aemm7rcUlcm0Y+xZkFLXDieFotMVu792+U6c8ci8lGXfm1XxipW HiEPxLUjC3f0uAdH5Mpb6LMrDb6hLHuk2wiyw7NixuFLk3ZujWOcv3NBH0r+JaP9ZMkrlf GZ4XLo6+g23DL7JKIRv0ogqQM7l41i+liZvq+ZXPxtBKfp1s7kf2q9thNCYwbg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dXthL203Lz1vd for ; Fri, 19 Dec 2025 16:45:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id b199 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 19 Dec 2025 16:45:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 8da838ac3169 - main - vtnet: improve consistency List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8da838ac31692e381adfc63d83ea49f2adabbf23 Auto-Submitted: auto-generated Date: Fri, 19 Dec 2025 16:45:54 +0000 Message-Id: <69458142.b199.511f6f8b@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=8da838ac31692e381adfc63d83ea49f2adabbf23 commit 8da838ac31692e381adfc63d83ea49f2adabbf23 Author: Michael Tuexen AuthorDate: 2025-12-19 16:44:20 +0000 Commit: Michael Tuexen CommitDate: 2025-12-19 16:44:20 +0000 vtnet: improve consistency Use sbuf_new_for_sysctl() instead of sbuf_new_auto() when exposing the flags via sysctl. MFC after: 1 week --- sys/dev/virtio/network/if_vtnet.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/sys/dev/virtio/network/if_vtnet.c b/sys/dev/virtio/network/if_vtnet.c index 73f34808e008..19775416f8d4 100644 --- a/sys/dev/virtio/network/if_vtnet.c +++ b/sys/dev/virtio/network/if_vtnet.c @@ -4417,16 +4417,14 @@ vtnet_sysctl_features(SYSCTL_HANDLER_ARGS) static int vtnet_sysctl_flags(SYSCTL_HANDLER_ARGS) { - struct vtnet_softc *sc; - struct sbuf *sb; + struct sbuf sb; + struct vtnet_softc *sc = (struct vtnet_softc *)arg1; int error; - sb = sbuf_new_auto(); - sc = (struct vtnet_softc *)arg1; - sbuf_printf(sb, "%b", sc->vtnet_flags, VTNET_FLAGS_BITS); - sbuf_finish(sb); - error = SYSCTL_OUT(req, sbuf_data(sb), sbuf_len(sb) + 1); - sbuf_delete(sb); + sbuf_new_for_sysctl(&sb, NULL, 0, req); + sbuf_printf(&sb, "%b", sc->vtnet_flags, VTNET_FLAGS_BITS); + error = sbuf_finish(&sb); + sbuf_delete(&sb); return (error); }