Date: Fri, 3 Apr 2015 14:03:45 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Anuranjan Shukla <anshukla@juniper.net> Cc: "arch@FreeBSD.org" <arch@FreeBSD.org>, "net@FreeBSD.org" <net@FreeBSD.org> Subject: Re: opaque ifnet progress Message-ID: <20150403110345.GM64665@glebius.int.ru> In-Reply-To: <D1433A4D.29410%anshukla@juniper.net> References: <20150319154309.GT64665@FreeBSD.org> <D1433A4D.29410%anshukla@juniper.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Anuranjan, On Fri, Apr 03, 2015 at 01:42:49AM +0000, Anuranjan Shukla wrote: A> Hello Gleb, A> Thanks for sharing the details. A> From looking at the wiki page it's not exactly clear what your plan is A> regarding the accessor functions as they stand today (if_get*/if_set* A> after drvapi change was made). I briefly glanced through some of the code A> changes but that takes time so it'd be good to know sort of the overall A> plan in that area if you foresee major rework. The plan is that they go away. They were a quick solution, that allow to avoid recompilation of a driver when struct ifnet change, but they still dictate the layout of the structure and don't give enough flexibility for the stacj to change in future. Also, new world order dictates that all change to flags/capenable/etc go directly through if_ioctl, so that we have one place to catch all events. Field accessor functions violate this rule. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150403110345.GM64665>