From owner-freebsd-bugs@FreeBSD.ORG Sat Jan 12 17:00:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3FB116A41B for ; Sat, 12 Jan 2008 17:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7B33F13C46E for ; Sat, 12 Jan 2008 17:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0CH01I9047312 for ; Sat, 12 Jan 2008 17:00:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0CH01Wb047311; Sat, 12 Jan 2008 17:00:01 GMT (envelope-from gnats) Resent-Date: Sat, 12 Jan 2008 17:00:01 GMT Resent-Message-Id: <200801121700.m0CH01Wb047311@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Antoine Brodin Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1741316A41A for ; Sat, 12 Jan 2008 16:51:02 +0000 (UTC) (envelope-from antoine@peanut.dreadbsd.org) Received: from peanut.dreadbsd.org (peanut.dreadbsd.org [82.67.196.50]) by mx1.freebsd.org (Postfix) with ESMTP id 611F813C442 for ; Sat, 12 Jan 2008 16:51:00 +0000 (UTC) (envelope-from antoine@peanut.dreadbsd.org) Received: from peanut.dreadbsd.org (localhost [127.0.0.1]) by peanut.dreadbsd.org (8.14.2/8.14.2) with ESMTP id m0CGolVL034860 for ; Sat, 12 Jan 2008 17:50:47 +0100 (CET) (envelope-from antoine@peanut.dreadbsd.org) Received: (from antoine@localhost) by peanut.dreadbsd.org (8.14.2/8.14.2/Submit) id m0CGolJv034859; Sat, 12 Jan 2008 17:50:47 +0100 (CET) (envelope-from antoine) Message-Id: <200801121650.m0CGolJv034859@peanut.dreadbsd.org> Date: Sat, 12 Jan 2008 17:50:47 +0100 (CET) From: Antoine Brodin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/119604: [patch] remove superfluous line in sys/kern/subr_autoconf.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Antoine Brodin List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2008 17:00:01 -0000 >Number: 119604 >Category: kern >Synopsis: [patch] remove superfluous line in sys/kern/subr_autoconf.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jan 12 17:00:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Antoine Brodin >Release: FreeBSD 8.0-CURRENT i386 >Organization: none >Environment: System: FreeBSD barton.dreadbsd.org. 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Jan 6 15:52:17 CET 2008 root@barton.dreadbsd.org.:/usr/obj/usr/src/sys/BARTON i386 >Description: There is a superfluous line in sys/kern/subr_autoconf.c:run_interrupt_driven_config_hooks The "next_entry = TAILQ_NEXT(hook_entry, ich_links);" is not necessary since TAILQ_FOREACH_SAFE is used. >How-To-Repeat: >Fix: --- subr_autoconf.c.diff begins here --- Index: subr_autoconf.c =================================================================== RCS file: /home/ncvs/src/sys/kern/subr_autoconf.c,v retrieving revision 1.23 diff -u -p -r1.23 subr_autoconf.c --- subr_autoconf.c 19 Jul 2006 18:53:56 -0000 1.23 +++ subr_autoconf.c 30 Dec 2007 19:39:36 -0000 @@ -67,7 +67,6 @@ run_interrupt_driven_config_hooks(dummy) mtx_lock(&intr_config_hook_lock); TAILQ_FOREACH_SAFE(hook_entry, &intr_config_hook_list, ich_links, next_entry) { - next_entry = TAILQ_NEXT(hook_entry, ich_links); mtx_unlock(&intr_config_hook_lock); (*hook_entry->ich_func)(hook_entry->ich_arg); mtx_lock(&intr_config_hook_lock); --- subr_autoconf.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: