From owner-cvs-all Thu Jun 6 10:31:58 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 68D0837B404; Thu, 6 Jun 2002 10:31:53 -0700 (PDT) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.3/8.12.2) with ESMTP id g56HVqJn089502; Thu, 6 Jun 2002 10:31:52 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.3/8.12.3/Submit) id g56HVqHF089501; Thu, 6 Jun 2002 10:31:52 -0700 (PDT) Date: Thu, 6 Jun 2002 10:31:52 -0700 From: "David O'Brien" To: "Tim J. Robbins" Cc: "Andrey A. Chernov" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/uniq uniq.c Message-ID: <20020606103152.D89287@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG Mail-Followup-To: David O'Brien , "Tim J. Robbins" , "Andrey A. Chernov" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200206060313.g563DAi26751@freefall.freebsd.org> <20020606031545.GA83612@nagual.pp.ru> <20020606161843.A44561@treetop.robbins.dropbear.id.au> <20020606083246.GA85860@nagual.pp.ru> <20020606192402.A45186@treetop.robbins.dropbear.id.au> <20020606100352.GA86621@nagual.pp.ru> <20020606202942.A45282@treetop.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020606202942.A45282@treetop.robbins.dropbear.id.au>; from tjr@FreeBSD.ORG on Thu, Jun 06, 2002 at 08:29:42PM +1000 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Jun 06, 2002 at 08:29:42PM +1000, Tim J. Robbins wrote: > > Please back it out. It break equality. Think about ss. > > Supply a test case and perhaps I shall. ..snip.. > This behavior is simply not correct, and the bug lies in FreeBSD's old > uniq implementation, not GNU sort. > > I shall not back this change out. Uh Tim, you need to back it out and do it now. *YOU* backed out ache's rev 1.7 (it seems w/o discussion): ---------------------------- revision 1.7 date: 1999-10-24 04:08:15; author: ache; state: Exp; lines: +18 -4 Use strcoll to provide the same results as sort and comm Use LINE_MAX for max line size (as comm does) ---------------------------- Ache knows a hell of a lot more about locale issues than us native English speakers do (ache vs. CJK people is an equal battle). He should be listened to in these cases. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message