From owner-cvs-all@FreeBSD.ORG Wed May 7 17:28:50 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3D66106566B; Wed, 7 May 2008 17:28:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 7D5DA8FC17; Wed, 7 May 2008 17:28:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unknown [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id 18C311A4D7C; Wed, 7 May 2008 10:28:49 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m47HSbaZ093757; Wed, 7 May 2008 13:28:37 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alfred Perlstein Date: Wed, 7 May 2008 11:11:39 -0400 User-Agent: KMail/1.9.7 References: <200805051603.m45G3rrN089219@repoman.freebsd.org> <200805051637.43073.jhb@freebsd.org> <20080507064013.GU32532@elvis.mu.org> In-Reply-To: <20080507064013.GU32532@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805071111.39938.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 07 May 2008 13:28:37 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7045/Tue May 6 23:00:44 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/stdio clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c xprintf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 17:28:50 -0000 On Wednesday 07 May 2008 02:40:13 am Alfred Perlstein wrote: > * John Baldwin [080505 13:47] wrote: > > On Monday 05 May 2008 03:24:17 pm Peter Jeremy wrote: > > > On Mon, May 05, 2008 at 02:59:28PM -0400, John Baldwin wrote: > > > >On Monday 05 May 2008 02:40:03 pm Alfred Perlstein wrote: > > > >> I'm _not_ objecting, just interested in why. > > > >> > > > >> Any references to discussions on this? Are we now safe for > > > >> future compat or something? > > > > > > > >Having FILE be opaque broke just about every 'configure' script on the > > > >planet. :( > > > > > > Either autoconf and friends are _intended_ as impediments to > > > portability or they are completely broken by design. > > > > It appears that autoconf only believes a type is real if you can typedef it to > > another type, cast 0 to a valid pointer to the new typedef'd type, and do a > > sizeof() of the typdef'd type. The last is where having an opaque type > > breaks down for scripts that want to make sure FILE is a real type. > > > Oh c'mon! we're going to revert this needed fix just because of > autoconf? Pretty much. It appears that FILE has been public for so long that there is a lot of code that assumes it can use it. -- John Baldwin