From owner-p4-projects Tue Mar 19 3:30: 3 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id EFB2037B402; Tue, 19 Mar 2002 03:29:53 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by hub.freebsd.org (Postfix) with ESMTP id 3DE4B37B400 for ; Tue, 19 Mar 2002 03:29:49 -0800 (PST) Received: from peter3.wemm.org ([12.232.27.13]) by rwcrmhc53.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020319112948.JQGN2951.rwcrmhc53.attbi.com@peter3.wemm.org> for ; Tue, 19 Mar 2002 11:29:48 +0000 Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id g2JBTms64745 for ; Tue, 19 Mar 2002 03:29:48 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 857FB3810; Tue, 19 Mar 2002 03:29:48 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Doug Rabson Cc: Perforce Change Reviews Subject: Re: PERFORCE change 7927 for review In-Reply-To: Date: Tue, 19 Mar 2002 03:29:48 -0800 From: Peter Wemm Message-Id: <20020319112948.857FB3810@overcee.wemm.org> Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Doug Rabson wrote: > On Tue, 19 Mar 2002, Peter Wemm wrote: > > > Doug Rabson wrote: > > > On Tue, 19 Mar 2002, Peter Wemm wrote: > > > > > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7927 > > > > > > > > Change 7927 by peter@peter_overcee on 2002/03/19 01:25:28 > > > > > > > > -Wunused > > > > > > As far as I'm concerned, most of this stuff can go right into CVS. In > > > fact, for most kernel work, I don't think there is a strong case for usin g > > > P4 for the ia64 stuff. > > > > It wasn't going to stay for more than a few hours. > > Oh, OK :-). I dont like committing something unless I've been able to make it work in some form. :-) There are still a few loose ends that I dont think can be committed as-is, eg: +++ //depot/projects/ia64/sys/contrib/dev/acpica/acmacros.h 2002/03/19 01:28:29 @@ -472,7 +472,8 @@ #define ACPI_FUNCTION_NAME(a) ACPI_DEBUG_PRINT_INFO _Dbg; \ _Dbg.ComponentId = _COMPONENT; \ - _Dbg.ProcName = a; \ + _Dbg.ProcName = \ + (NATIVE_CHAR *)(uintptr_t)a; \ _Dbg.ModuleName = _THIS_MODULE; #define ACPI_FUNCTION_TRACE(a) ACPI_FUNCTION_NAME(a)\ This is unhappy with gcc-3.1, where the [ab]use of __func__ in dev/acpica/* is causing a lot of compiler spewage. I can either change the ACPI_FUNCTION_TRACE(__func__); lines to ACPI_FUNCTION_TRACE("acpi_function"); like they probably should have been to start with. Touching the macro is easier, but takes the file off the vendor branch. Same here: +++ //depot/projects/ia64/sys/contrib/dev/acpica/nsxfobj.c 2002/03/11 01:37:50 @@ -309,7 +309,7 @@ */ ACPI_DEBUG_PRINT ((ACPI_DB_INFO, "Needed buffer size %X, %s\n", - BufferSpaceNeeded, AcpiFormatException (Status))); + (int)BufferSpaceNeeded, AcpiFormatException (Status))); } else { and about another 20 of these.. I added ended up adding -Wno-format to my CFLAGS :-) These can probably go. I do regularly check the diff to make sure that I'm not sitting on something that should be in the tree. It only takes 4.5 seconds to diff the entire tree (45000 files) relative to the last integrate point. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message