Date: Tue, 19 Mar 2002 03:29:48 -0800 From: Peter Wemm <peter@wemm.org> To: Doug Rabson <dfr@nlsystems.com> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 7927 for review Message-ID: <20020319112948.857FB3810@overcee.wemm.org> In-Reply-To: <Pine.BSF.4.33.0203191037530.7670-100000@herring.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Rabson wrote: > On Tue, 19 Mar 2002, Peter Wemm wrote: > > > Doug Rabson wrote: > > > On Tue, 19 Mar 2002, Peter Wemm wrote: > > > > > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7927 > > > > > > > > Change 7927 by peter@peter_overcee on 2002/03/19 01:25:28 > > > > > > > > -Wunused > > > > > > As far as I'm concerned, most of this stuff can go right into CVS. In > > > fact, for most kernel work, I don't think there is a strong case for usin g > > > P4 for the ia64 stuff. > > > > It wasn't going to stay for more than a few hours. > > Oh, OK :-). I dont like committing something unless I've been able to make it work in some form. :-) There are still a few loose ends that I dont think can be committed as-is, eg: +++ //depot/projects/ia64/sys/contrib/dev/acpica/acmacros.h 2002/03/19 01:28:29 @@ -472,7 +472,8 @@ #define ACPI_FUNCTION_NAME(a) ACPI_DEBUG_PRINT_INFO _Dbg; \ _Dbg.ComponentId = _COMPONENT; \ - _Dbg.ProcName = a; \ + _Dbg.ProcName = \ + (NATIVE_CHAR *)(uintptr_t)a; \ _Dbg.ModuleName = _THIS_MODULE; #define ACPI_FUNCTION_TRACE(a) ACPI_FUNCTION_NAME(a)\ This is unhappy with gcc-3.1, where the [ab]use of __func__ in dev/acpica/* is causing a lot of compiler spewage. I can either change the ACPI_FUNCTION_TRACE(__func__); lines to ACPI_FUNCTION_TRACE("acpi_function"); like they probably should have been to start with. Touching the macro is easier, but takes the file off the vendor branch. Same here: +++ //depot/projects/ia64/sys/contrib/dev/acpica/nsxfobj.c 2002/03/11 01:37:50 @@ -309,7 +309,7 @@ */ ACPI_DEBUG_PRINT ((ACPI_DB_INFO, "Needed buffer size %X, %s\n", - BufferSpaceNeeded, AcpiFormatException (Status))); + (int)BufferSpaceNeeded, AcpiFormatException (Status))); } else { and about another 20 of these.. I added ended up adding -Wno-format to my CFLAGS :-) These can probably go. I do regularly check the diff to make sure that I'm not sitting on something that should be in the tree. It only takes 4.5 seconds to diff the entire tree (45000 files) relative to the last integrate point. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020319112948.857FB3810>