From owner-svn-src-all@freebsd.org Tue Sep 3 14:20:39 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9F584E88F1 for ; Tue, 3 Sep 2019 14:20:39 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N8Hp6CRWz3CTC for ; Tue, 3 Sep 2019 14:20:38 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk1-x743.google.com with SMTP id z67so3201105qkb.12 for ; Tue, 03 Sep 2019 07:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tQwRAC5gTLZ1NXCwkJyTX9GC9CeLvGjIIpIzK3C2TmA=; b=jhxKcHRPI59/DTjWO4fdjMq2CEvyzl8gutqlnb5J/KaBtdm4KUeEQqvhwaW6nXPowW rGptiz94AU6+vbBWLZFUQbaMOd7s1VmJ3QL2R2nYcdK9VUYQO00HN1kmstfczdaya0W1 vmChehvsszumsqXU1mtRN72i2DU+lV3wpk6jW4rJMJVuxOhahNumPgNFXqK4JQhlUE98 TkzUQOiH4Zrw1pLEnQzZMgnThzAjTz4/VpBKqDr22bSXJEpCJ5FWjfA7DTXgI7EgJVN9 sU2xI0F78/zsZCqy8Jb2puH3LtmGN8adlbQti5oHS+klcCrrnlpsK90gRJpd3KsTLrXz 6gzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tQwRAC5gTLZ1NXCwkJyTX9GC9CeLvGjIIpIzK3C2TmA=; b=Q7U5WcejGQsa0VuHf34yDFeLPmoAyihFL1kPW0ed5VoB5SxrIvobllDNzYSkT7TCir /Mq/PNAJd/xsyWVaEnVSJOODyD/HbeIaJivcl4e6UQUS3r8L2AiikirdXqB/oS2k7GnP OxHbiQlgmcYTWIRERMDxl+mPv9r2hHNHx3PpodYDTOlH8xwh6yaMDNn6RBZLvO6A2Rn+ 9E6FcHmL82MA5bMyszz19RUaeBMsScgHAVWA/3EgD1ibEZwa5n9dtemlApeJj4ihbMbu Bal0e+5YhHkDNNMUOU7abVUKxy1mPPwWBSeWZbydmHBCnbK7OFUaxbmnKnJ22riBtg2v GI0Q== X-Gm-Message-State: APjAAAU6m96oev3dsOgyzOFuezvMJ6ujduM88+cEa3cC+HdupeJIfPEi VRQPpafdHG/iUIlMrhQPNj91Fzh+WY4= X-Google-Smtp-Source: APXvYqzlS12mkU81m6xI5dr6jJCfykwyfjNXdlpYyJZQreBJLAZvi9DsRmcQJvPFiFK9UJnznVmvFg== X-Received: by 2002:a37:de13:: with SMTP id h19mr18424807qkj.327.1567520437134; Tue, 03 Sep 2019 07:20:37 -0700 (PDT) Received: from mutt-hbsd ([63.88.83.108]) by smtp.gmail.com with ESMTPSA id r189sm8565756qkc.60.2019.09.03.07.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 07:20:36 -0700 (PDT) Date: Tue, 3 Sep 2019 10:20:35 -0400 From: Shawn Webb To: Brooks Davis Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20190903142035.w7tuqow4impv6bkx@mutt-hbsd> References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> <20190903114740.gbzkeffdce3mkee2@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zd2nnc4k5pr2bgd5" Content-Disposition: inline In-Reply-To: <20190903114740.gbzkeffdce3mkee2@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 46N8Hp6CRWz3CTC X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=jhxKcHRP; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::743 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-5.55 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; RCVD_IN_DNSWL_NONE(0.00)[3.4.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-0.47)[ip: (2.80), ipnet: 2607:f8b0::/32(-2.81), asn: 15169(-2.30), country: US(-0.05)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 14:20:39 -0000 --zd2nnc4k5pr2bgd5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 03, 2019 at 07:47:40AM -0400, Shawn Webb wrote: > On Tue, Sep 03, 2019 at 11:45:23AM +0000, Brooks Davis wrote: > > On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: > > > Hey Mateusz, > > >=20 > > > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: > > > > Author: mjg > > > > Date: Tue Sep 3 04:16:30 2019 > > > > New Revision: 351729 > > > > URL: https://svnweb.freebsd.org/changeset/base/351729 > > > >=20 > > > > Log: > > > > Add sysctlbyname system call > > > > =20 > > > > Previously userspace would issue one syscall to resolve the sysct= l and then > > > > another one to actually use it. Do it all in one trip. > > > > =20 > > > > Fallback is provided in case newer libc happens to be running on = an older > > > > kernel. > > > > =20 > > > > Submitted by: Pawel Biernacki > > > > Reported by: kib, brooks > > > > Differential Revision: https://reviews.freebsd.org/D17282 > > > >=20 > > > > Modified: > > > ... snip ... > > > > head/sys/sys/param.h > > >=20 > > > ... snip ... > > >=20 > > > >=20 > > > > Modified: head/sys/sys/param.h > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 2019 (r351728) > > > > +++ head/sys/sys/param.h Tue Sep 3 04:16:30 2019 (r351729) > > > > @@ -60,7 +60,7 @@ > > > > * in the range 5 to 9. > > > > */ > > > > #undef __FreeBSD_version > > > > -#define __FreeBSD_version 1300044 /* Master, propagated to newvers= */ > > > > +#define __FreeBSD_version 1300045 /* Master, propagated to newvers= */ > > >=20 > > > To an outsider, it seems that __FreeBSD_version tends to be bumped in > > > a separate commit. Am I remembering that right? > >=20 > > It should be bumped in the same commit, but people forget or the bump > > they have in their review turns into a no-op because someone else does a > > bump in the interim (the latter has bit me several times). >=20 > Interesting. Thanks for the clarification! One thought for making the version bump a seperate commit is if the original commit needed to be reverted, the commit can be reverted wholesale (well, from the perspective of __FreeBSD_version) without worry of accidentally decrementing the version number to a prior value. That's my "need-more-caffeine" verbose way of saying "separating the version bump from the actual work allows for easier maintenance of the version number, helping ensure an always-increasing number." Sorry if I sound dry here. My ten-month-old puppy is tiring me out way faster than I can tire him out. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --zd2nnc4k5pr2bgd5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl1udq0ACgkQ/y5nonf4 4fo24RAApLwy0mX8sHuEQxXcavCdaYn8oKS/8YpzS07Eos9s4zIt+tLKhI9J0i9T +atjSmRI/sCiWW/zRPd1kWPwMOUbW3ITkZ6v+Kqb9SAw4D+HHzynOrU0w2AKCS4l dFxjorpMqxa41M023uWL95qYsHxC8vZqcgwqs5111Si75Z7HeG0n9siefAcYEIap AV4dYrYr4JMTWisQ46hSIghIqRXFestNdFeH/gA2+Ym+6h1T9Fu3mIayuM7fPYA0 SxWxzI/srwLnRrL2NXI/8uOEtfZsnI0ClBYxcCPs/EyXuScYWFC24J9vJxrOomBV mqdGF+OG0HmF8STnfioSRa/Kkddv2KkwUsnq41yvbanDY7eJVIm3ncFOVCaW+D+Q MZmpos50oLueygcJD+XYngsSAq2uzPZIKuwPjCs3pTw5RdtiSynTZYk9DWfd79Mf qFTgn+Y9ZOcpkTG0xOIFeKkk3cvfrdORKwqaf5vuPwlb1QTmBEIbeOzcK9BpRgT1 PTlOEX+hwSpJkIUDxnBL88X6Jb/tf1J1tZa0iIopHBb49LaUTbq7fNdSPxUjpSLS T27hja58rFAzBqtv6MdgfmSWwbia59J1EFjORCOyH7Mcf9EfkVwPPnvewFdVnUUe NtSHofRrRyb6wcAtpmN7LXCOkuaqhaD7bmrqcp2LS5Hq07aELFI= =31c1 -----END PGP SIGNATURE----- --zd2nnc4k5pr2bgd5--