Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Sep 2014 06:46:28 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 182209] [new port] emulators/hyperv-ic: Ports containing Hyper-V integration components for FreeBSD
Message-ID:  <bug-182209-13-oF91oZ6r8z@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-182209-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-182209-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=182209

--- Comment #29 from John Marino <marino@FreeBSD.org> ---
additional comments then:

XFILE_84=    ${PORTNAME}-8.4.${PORTVERSION}${EXTRACT_SUFX}

Don't use ${PORTNAME}, use hardcoded text.  If I change the PORTNAME, the port
breaks unnecessarily.  (People commonly use ${PORTNAME} when any value of
${PORTNAME} other than the current value is outright wrong, and I don't
understand why.  I guess it's a pet peeve with me at this point)

Also, in your validity check, check ${OPSYS} == FreeBSD.  If it does not,
IGNORE should be set.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-182209-13-oF91oZ6r8z>