From owner-freebsd-gecko@FreeBSD.ORG  Mon Apr  4 11:29:19 2011
Return-Path: <owner-freebsd-gecko@FreeBSD.ORG>
Delivered-To: gecko@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2FCB4106564A;
	Mon,  4 Apr 2011 11:29:19 +0000 (UTC)
	(envelope-from decke@FreeBSD.org)
Received: from groupware.itac.at (groupware.itac.at [91.205.172.99])
	by mx1.freebsd.org (Postfix) with ESMTP id BA25B8FC0A;
	Mon,  4 Apr 2011 11:29:18 +0000 (UTC)
Received: from home.bluelife.at (93.104.210.95) by groupware.itac.at (Axigen)
	with (AES256-SHA encrypted) ESMTPSA id 2C1766;
	Mon, 4 Apr 2011 13:29:18 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Date: Mon, 04 Apr 2011 13:29:18 +0200
From: Bernhard Froehlich <decke@FreeBSD.org>
To: <beat@FreeBSD.org>
In-Reply-To: <201103290607.p2T674ob067019@freefall.freebsd.org>
References: <201103290607.p2T674ob067019@freefall.freebsd.org>
Message-ID: <af60d368b06964a62e07b628e939fd75@bluelife.at>
X-Sender: decke@FreeBSD.org
User-Agent: Roundcube Webmail/0.5.1
X-AxigenSpam-Level: 1
X-CTCH-RefID: str=0001.0A0B0201.4D99AB8D.0121,ss=1,fgs=0
X-CTCH-VOD: Unknown
X-CTCH-Spam: Unknown
Cc: gecko@FreeBSD.org, kalten@gmx.at
Subject: Re: ports/155949: www/firefox: firefox 4, WITH_PGO,
 better Text against DISPLAY problem
X-BeenThere: freebsd-gecko@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Gecko Rendering Engine issues <freebsd-gecko.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gecko>
List-Post: <mailto:freebsd-gecko@freebsd.org>
List-Help: <mailto:freebsd-gecko-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Apr 2011 11:29:19 -0000

I think the cleanest solution would be a check before starting build to
detect if X is available or not. (ideally configure or otherwise port
Makefile) But if we are talking about PGO removal do we have some
numbers how much speed you gain? I don't feel any differences on my
machine and JS benchmarks are about the same. Mozilla ships his own
Firefox binaries all without PGO so I'm not sure about the support of
that optimizations.

Drawbacks:
1) 2 full compiler runs - build time about ~2.5x
2) requires X to actually run the binary and do some profiling
3) it tends to fail in some cases

-- 
Bernhard Froehlich
http://www.bluelife.at/