From owner-cvs-all Fri Jan 28 13:44: 8 2000 Delivered-To: cvs-all@freebsd.org Received: from jade.chc-chimes.com (jade.chc-chimes.com [216.28.46.6]) by hub.freebsd.org (Postfix) with ESMTP id A583215546; Fri, 28 Jan 2000 13:44:04 -0800 (PST) (envelope-from billf@jade.chc-chimes.com) Received: by jade.chc-chimes.com (Postfix, from userid 1001) id 0FDD51C41; Fri, 28 Jan 2000 16:44:04 -0500 (EST) Date: Fri, 28 Jan 2000 16:44:04 -0500 From: Bill Fumerola To: Brian Fundakowski Feldman Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen Makefile.inc Message-ID: <20000128164403.H31717@jade.chc-chimes.com> References: <200001280714.XAA38397@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from green@FreeBSD.org on Fri, Jan 28, 2000 at 04:32:12PM -0500 X-Operating-System: FreeBSD 3.2-RELEASE i386 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Fri, Jan 28, 2000 at 04:32:12PM -0500, Brian Fundakowski Feldman wrote: > Am I the only one that's disturbed by the fact that this (nonstandard) > function pair has such generic names? Already, it has broken world > in two places. It's just not a good idea to have such generic functions > in our headers (even if it's more okay for them to be in the libaries...) > > How about (for instance) strflags() for getflags() and strtoflags() for > setflags()? The names right now are extremely ambigous, plus getflags() > returns a pointer to a STATIC BUFFER, a very bad and inherently messy, > thread-unsafe, etc. etc. thing. Plus, it's not even noted in the manpage. I thought I read somewhere that str*() functions were reserved, so wouldn't we be replacing non-standard function names with standard-breaking functions? Of course, I could just be remembering wrong, in which case 10 people will flame me. -- Bill Fumerola - Network Architect Computer Horizons Corp - CVM e-mail: billf@chc-chimes.com / billf@FreeBSD.org Office: 800-252-2421 x128 / Cell: 248-761-7272 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message