From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 19 17:00:51 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9EE5516A50A for ; Sun, 19 Dec 2004 17:00:51 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73AAA43D2F for ; Sun, 19 Dec 2004 17:00:51 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBJH0pSI087771 for ; Sun, 19 Dec 2004 17:00:51 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBJH0o7E087758; Sun, 19 Dec 2004 17:00:51 GMT (envelope-from gnats) Resent-Date: Sun, 19 Dec 2004 17:00:51 GMT Resent-Message-Id: <200412191700.iBJH0o7E087758@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Palle Girgensohn Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E4F216A4CE; Sun, 19 Dec 2004 16:52:07 +0000 (GMT) Received: from palle.girgensohn.se (1-2-8-5a.asp.sth.bostream.se [82.182.157.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id A17BC43D55; Sun, 19 Dec 2004 16:52:06 +0000 (GMT) (envelope-from girgen@palle.girgensohn.se) Received: from localhost (localhost.girgensohn.se [127.0.0.1]) by palle.girgensohn.se (Postfix) with ESMTP id 8513E1CE37; Sun, 19 Dec 2004 17:52:39 +0100 (CET) Received: from palle.girgensohn.se ([127.0.0.1]) by localhost (palle.girgensohn.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 05195-10; Sun, 19 Dec 2004 17:52:39 +0100 (CET) Received: by palle.girgensohn.se (Postfix, from userid 1000) id 25E1B1CE2D; Sun, 19 Dec 2004 17:52:39 +0100 (CET) Message-Id: <20041219165239.25E1B1CE2D@palle.girgensohn.se> Date: Sun, 19 Dec 2004 17:52:39 +0100 (CET) From: Palle Girgensohn To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: gnome@FreeBSD.org Subject: ports/75262: [PATCH] www/firefox: error running firefox -v X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Dec 2004 17:00:51 -0000 >Number: 75262 >Category: ports >Synopsis: [PATCH] www/firefox: error running firefox -v >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Dec 19 17:00:50 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Palle Girgensohn >Release: FreeBSD 5.3-RELEASE-p1 i386 >Organization: Ping Pong AB >Environment: System: FreeBSD palle.girgensohn.se 5.3-RELEASE-p1 FreeBSD 5.3-RELEASE-p1 #16: Sat Nov 20 04:26:58 CET 2004 >Description: when running firefox -v, an error is generated. This confuses for example firefox-remote, so there's always an error whenn running it. This is especially annoying when using a GUI emailer - clicking a URL in an email always give an error dialouge. Port maintainer (gnome@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.63 >How-To-Repeat: $ /usr/X11R6/bin/firefox -V expr: illegal option -- V usage: expr [-e] expression [: -eq: unexpected operator Mozilla Firefox 1.0, Copyright (c) 2004 mozilla.org >Fix: The check only searchs for the string ':/', so an extra prefix X will not disturb it: --- firefox-1.0_5,1.patch begins here --- Index: files/patch-browser_app_mozilla.in =================================================================== RCS file: /home/ncvs/ports/www/firefox/files/patch-browser_app_mozilla.in,v retrieving revision 1.3 diff -u -u -r1.3 patch-browser_app_mozilla.in --- files/patch-browser_app_mozilla.in 20 Nov 2004 20:24:36 -0000 1.3 +++ files/patch-browser_app_mozilla.in 19 Dec 2004 16:45:40 -0000 @@ -1,5 +1,5 @@ ---- browser/app/mozilla.in.orig Sat Nov 13 00:54:51 2004 -+++ browser/app/mozilla.in Sat Nov 13 00:57:22 2004 +--- browser/app/mozilla.in.orig Tue Oct 26 11:26:11 2004 ++++ browser/app/mozilla.in Sun Dec 19 17:44:44 2004 @@ -110,6 +110,7 @@ # Check default compile-time libdir if [ -x "$moz_libdir/run-mozilla.sh" ]; then @@ -8,7 +8,16 @@ else echo "Cannot find mozilla runtime directory. Exiting." exit 1 -@@ -207,12 +207,31 @@ +@@ -160,7 +161,7 @@ + _optLast="${i}" + done #last arg + +-if [ `expr "${_optLast}" : '.*:/.*'` -eq 0 -a \( -f "${_optLast}" -o -d "${_optLast}" \) ]; then ++if [ `expr X"${_optLast}" : '.*:/.*'` -eq 0 -a \( -f "${_optLast}" -o -d "${_optLast}" \) ]; then + # Last argument seems to be a local file/directory + # Check, if it is absolutely specified (ie. /home/foo/file vs. ./file) + # If it is just "relatively" (./file) specified, make it absolutely +@@ -207,12 +208,31 @@ script_args="$script_args -d $2" shift 2 ;; --- firefox-1.0_5,1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: