Date: Tue, 22 Dec 2020 20:12:11 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 251987] multimedia/get_iplayer: rc.d script emits error message even when disabled Message-ID: <bug-251987-7788-B6o6KnrPAS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-251987-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-251987-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251987 --- Comment #5 from Jamie Landeg-Jones <jamie@catflap.org> --- (In reply to Niels Bakker from comment #4) Ahh, ok. Yes, the whole thing is passed through "eval", and would otherwise fail without quotes if the home directory contained the space character, wh= ich is perfectly valid. So the patch works. However, on further inspection, rc.subr itself isn't compatible with space = in directories (xxx_chdir fails), so I guess this is moot. Of course, the single quoting will still cause the script to fail if the pa= th contains a "'", but this is opening up another can of worms.... The whole rc.subr system needs to be changed to cope with shell-special characters really. However, I have updated the patch to use the proper way of exporting variab= les to daemons, and also fixed a typo in the original pkg-message. Is this ok? Cheers, Jamie --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-251987-7788-B6o6KnrPAS>