From owner-cvs-all@FreeBSD.ORG  Tue Aug 31 20:45:37 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A98AC16A5D0; Tue, 31 Aug 2004 20:45:07 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7135143D48; Tue, 31 Aug 2004 20:45:07 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.11/8.12.11) with ESMTP id i7VKhSZB070925;
	Tue, 31 Aug 2004 14:43:28 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 31 Aug 2004 14:43:38 -0600 (MDT)
Message-Id: <20040831.144338.66325058.imp@bsdimp.com>
To: nate@root.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <4134A9E9.7090008@root.org>
References: <200408302135.i7ULZYQx028502@repoman.freebsd.org>
	<20040831070313.GC30959@ip.net.ua>
	<4134A9E9.7090008@root.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: ru@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/fdc fdc_acpi.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Aug 2004 20:45:38 -0000

In message: <4134A9E9.7090008@root.org>
            Nate Lawson <nate@root.org> writes:
: Ruslan Ermilov wrote:
: > On Mon, Aug 30, 2004 at 09:35:34PM +0000, Nate Lawson wrote:
: > 
: >>njl         2004-08-30 21:35:34 UTC
: >>
: >>  FreeBSD src repository
: >>
: >>  Modified files:
: >>    sys/dev/fdc          fdc_acpi.c 
: >>  Log:
: >>  Fix _FDI drive type probing.  The new fd child is not an ACPI device while
: >>  the old one is.  Hence we need to evaluate the old one for _FDI since it
: >>  has a valid ACPI_HANDLE ivar.  This is a minimal fix.  Make a note that a
: >>  more complete one is to make fdc support the ACPI_HANDLE ivar for its
: >>  children.
: >>  
: >>  This and the previous change are MT5 candidates.
: >>  
: >>  Revision  Changes    Path
: >>  1.5       +10 -3     src/sys/dev/fdc/fdc_acpi.c
: >>
: > 
: > Should I retry on my ThinkPad 600X with these two changes?
: 
: Sure but I think yours was a resource problem and you don't have _FDE 
: probing.

I'm working the resource problem right now...

Warner