From owner-freebsd-fs@FreeBSD.ORG  Mon Sep  3 12:21:38 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 39A12106566C
	for <freebsd-fs@FreeBSD.org>; Mon,  3 Sep 2012 12:21:38 +0000 (UTC)
	(envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 708A58FC1E
	for <freebsd-fs@FreeBSD.org>; Mon,  3 Sep 2012 12:21:37 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA21449;
	Mon, 03 Sep 2012 15:21:33 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <5044A0CC.1000401@FreeBSD.org>
Date: Mon, 03 Sep 2012 15:21:32 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:15.0) Gecko/20120830 Thunderbird/15.0
MIME-Version: 1.0
To: Trent Nelson <trent@snakebite.org>
References: <20120824011517.GJ42732@snakebite.org>
	<503CD4F1.6060001@FreeBSD.org> <503CDD4E.6050902@FreeBSD.org>
	<20120831230553.GC59852@snakebite.org>
In-Reply-To: <20120831230553.GC59852@snakebite.org>
X-Enigmail-Version: 1.4.3
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: "freebsd-fs@FreeBSD.org" <freebsd-fs@FreeBSD.org>
Subject: Re: chmod -h 000x against symlink has bizarre results on ZFS
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Sep 2012 12:21:38 -0000

on 01/09/2012 02:05 Trent Nelson said the following:
> On Tue, Aug 28, 2012 at 08:01:34AM -0700, Andriy Gapon wrote:
>> on 28/08/2012 17:25 Andriy Gapon said the following:
>> Will you be able to test the following patch?
>> Preferably on a temporary test pool - I don't want to risk your data.
>>
>> diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
>> b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
>> index 69374fb..7f61517 100644
>> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
>> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
>> @@ -1695,6 +1695,7 @@ sa_modify_attrs(sa_handle_t *hdl, sa_attr_type_t newattr,
>>  				ASSERT(action == SA_REPLACE);
>>  				SA_ADD_BULK_ATTR(attr_desc, j, attr,
>>  				    locator, datastart, buflen);
>> +				length_idx++;
>>  			} else {
>>  				length = SA_REGISTERED_LEN(sa, attr);
>>  				if (length == 0) {
>>
> 
>     That looks like it did the trick.  Nice one :-)

Thank you very much for testing and reporting!

>     What's the protocol for ZFS bugfixes?  I'm happy to do the leg work
>     (submitting PRs to other teams etc).

I am already discussing this issue with Illumos guys.
Thank you for the offer.

-- 
Andriy Gapon