From owner-freebsd-wireless@freebsd.org Thu May 19 18:03:08 2016 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 826DEB4242A for ; Thu, 19 May 2016 18:03:08 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 07E6B17B2; Thu, 19 May 2016 18:03:08 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: by mail-lf0-x244.google.com with SMTP id 78so2374949lfq.0; Thu, 19 May 2016 11:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=IPOgZXmOdvxefbnOdUcx1xJzJriXO/prHweelp8oa7M=; b=pFQDeVf0bElDrKOU8KRlLHEk5hs6vuf8k6+IgT1n3Eu2CXuEzKAD3wXsjgi+7k+NxK +6mgZIJmiTmjbczjyL7jBBvg3j+n1+D9UA9ANwIqrwPIp+4znxUx4E74r1yuW4P1uZiK pgTGGbWRDG8MCTubKB/O+BcQYrOnx7TrrvGCOi6RoB51qvxzKGpVcysX05M6aSDnm7LF 6z6IqFC+Dia5gsr7JaBoLGwZT6vcriiEOinbpD2ZL/2Nq5yLXas8GhSg1pCQBhPRj1rq TbSIF1puDxahBbckTugXllWg/rFbNbB6pgWwWVT2yNdsfJVDaj4vkTm9i0nXRYeXb6Ow h8qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=IPOgZXmOdvxefbnOdUcx1xJzJriXO/prHweelp8oa7M=; b=PaedQfgBjjnW59AE0yqBYTCjxYwS00xwU8zYWIMYz0YfPWlJl7S5cray2Fpo/1MV/G 7PK7Z0NspXoAEuby9le5OcKukXySegEnRFIbu2swcBeFHEXA+H7eTsginvvbWmBb57ms MSaU3bSJVgrp+t2lFpqDkECBT+LmdvOJdlXWZXB0pHGFywRYg2R8kgSszKiGQ3/a37Zb 0/TJ01qp8O/KeI96d7RFGE1mEkM/iDsySlr/U7P4xsf0NIzO3ePn5wdqwaCq8IGRqagM lcq4JoEYAd/HrYbOTeNcwM2gdAIfS94RPXlv2HfbgDQPjDpRgoyTGEvMUQ7cfQuMoRg2 hl7A== X-Gm-Message-State: AOPr4FXa7htWm/0Q4blOr0gmlcD5Vmilw+VO+eQ/zzJ8EB7gmxG1FXHpcj/aJAvkllJSEQ== X-Received: by 10.25.160.77 with SMTP id j74mr4689983lfe.72.1463680985015; Thu, 19 May 2016 11:03:05 -0700 (PDT) Received: from localhost (host-176-37-109-22.la.net.ua. [176.37.109.22]) by smtp.gmail.com with ESMTPSA id w17sm2604799lfd.45.2016.05.19.11.03.02 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 19 May 2016 11:03:04 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Adrian Chadd" Cc: "Don Lewis" , "freebsd-wireless@freebsd.org" Subject: Re: minor array overflow in ifconfig set80211chanlist() References: <201605162142.u4GLgs8d072880@gw.catspoiler.org> Date: Thu, 19 May 2016 21:02:56 +0300 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 18:03:08 -0000 Tue, 17 May 2016 01:05:57 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Andriy Voskoboinyk = : > Tue, 17 May 2016 01:03:03 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd = > : > >> Heh, god, it's used for both maximum ieee channel number /and/ the >> array size? we should eventually fix that; 11ac channels will likely >> overflow all of the above. :( > > No (yes) :) > I mean ic->ic_nchans and nitems(ic->ic_channels) > ... but you are right: ic_ieee is uint8_t, so it's limited by this = > number too. > ... but there is another macro with the same value: ieee80211_scan_sta.c: #define MAX_IEEE_CHAN 256 /* max acceptable IEEE chan # */ CTASSERT(MAX_IEEE_CHAN >=3D 256); >> >> >> >> -a >> _______________________________________________ >> freebsd-wireless@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-wireless >> To unsubscribe, send any mail to = >> "freebsd-wireless-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to = > "freebsd-wireless-unsubscribe@freebsd.org"