From owner-freebsd-current@freebsd.org  Tue Dec  8 15:50:50 2020
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19C9D4A41AE
 for <freebsd-current@mailman.nyi.freebsd.org>;
 Tue,  8 Dec 2020 15:50:50 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::50:13])
 by mx1.freebsd.org (Postfix) with ESMTP id 4Cr4Qf07x0z4WPc
 for <freebsd-current@freebsd.org>; Tue,  8 Dec 2020 15:50:50 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mailman.nyi.freebsd.org (Postfix)
 id 0311A4A40E3; Tue,  8 Dec 2020 15:50:50 +0000 (UTC)
Delivered-To: current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 02D9E4A3FE2
 for <current@mailman.nyi.freebsd.org>; Tue,  8 Dec 2020 15:50:50 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4Cr4Qd6jLgz4Wd8;
 Tue,  8 Dec 2020 15:50:49 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com
 [209.85.222.177])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id D715720951;
 Tue,  8 Dec 2020 15:50:49 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qk1-f177.google.com with SMTP id z11so7133714qkj.7;
 Tue, 08 Dec 2020 07:50:49 -0800 (PST)
X-Gm-Message-State: AOAM531vgrTacjqRUxPwvnVPcyxYuBlyd7QcXgUVudt9qb+lkalP32jL
 HEnChUSs39Y6TzdKI2Q7zhIAyfCjlHNYXhD7OFc=
X-Google-Smtp-Source: ABdhPJy9l+OfgjjYjo446RkOxAEgGQfAMoFD2WJHOCUoGS5EQdvUlpnBFapNfWDYUEhhaWGHlOz6rpHkA5SsL44UBrs=
X-Received: by 2002:a05:620a:14a:: with SMTP id
 e10mr13382606qkn.103.1607442649541; 
 Tue, 08 Dec 2020 07:50:49 -0800 (PST)
MIME-Version: 1.0
References: <20201208114718.GA33199@x8.osted.lan> <X8+cIUFKzzOSnl4L@raichu>
 <CACNAnaG_8iSUqc3pnmV-DMFQ_+Q+bSDbYA8X3pz743rRGUtT9A@mail.gmail.com>
 <X8+gTfsqOCxld3yl@raichu>
In-Reply-To: <X8+gTfsqOCxld3yl@raichu>
From: Kyle Evans <kevans@freebsd.org>
Date: Tue, 8 Dec 2020 09:50:35 -0600
X-Gmail-Original-Message-ID: <CACNAnaEYaUX_XVFQ1MKn9nD5UBwNeLViAXZVRMZHsXcLDFxoRQ@mail.gmail.com>
Message-ID: <CACNAnaEYaUX_XVFQ1MKn9nD5UBwNeLViAXZVRMZHsXcLDFxoRQ@mail.gmail.com>
Subject: Re: panic: general protection fault from uipc_sockaddr+0x4c
To: Mark Johnston <markj@freebsd.org>
Cc: Peter Holm <pho@freebsd.org>, current <current@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2020 15:50:50 -0000

On Tue, Dec 8, 2020 at 9:48 AM Mark Johnston <markj@freebsd.org> wrote:
>
> On Tue, Dec 08, 2020 at 09:39:05AM -0600, Kyle Evans wrote:
> > On Tue, Dec 8, 2020 at 9:30 AM Mark Johnston <markj@freebsd.org> wrote:
> > > kern_proc_filedesc_out() holds the fdtable shared lock thoughout all of
> > > this, which is supposed to prevent the table entry from being freed
> > > since that requires the exclusive lock.
> > >
> >
> > export_file_to_sb drops the lock without it or kern_proc_filedesc_out
> > holding the file it's about to look at, though.
>
> Yes, but that's after it calls fo_fill_kinfo().  At that point it has
> already collected the to-be-exported info in an sbuf.

Whoops, indeed- sorry.