From owner-cvs-all@FreeBSD.ORG Tue Mar 21 22:11:05 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D1C416A400; Tue, 21 Mar 2006 22:11:05 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id A434443D48; Tue, 21 Mar 2006 22:11:02 +0000 (GMT) (envelope-from keramida@ceid.upatras.gr) Received: from flame.pc (igloo.linux.gr [62.1.205.36]) by igloo.linux.gr (8.13.5/8.13.5/Debian-3) with ESMTP id k2LMAZXd016345; Wed, 22 Mar 2006 00:10:38 +0200 Received: by flame.pc (Postfix, from userid 1001) id 025ECA4; Tue, 21 Mar 2006 13:18:49 -0800 (PST) Date: Tue, 21 Mar 2006 13:18:48 -0800 From: Giorgos Keramidas To: Dag-Erling Smorgrav Message-ID: <20060321211848.GA87662@flame.pc> References: <200603210808.k2L88xvQ014794@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200603210808.k2L88xvQ014794@repoman.freebsd.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-3.313, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 1.09, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/tinderbox tbmaster.pl X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2006 22:11:05 -0000 On 2006-03-21 08:08, Dag-Erling Smorgrav wrote: > des 2006-03-21 08:08:58 UTC > > FreeBSD src repository > > Modified files: > tools/tools/tinderbox tbmaster.pl > Log: > Open the lock file write-only. > > Revision Changes Path > 1.62 +1 -1 src/tools/tools/tinderbox/tbmaster.pl For anyone wondering why this change is needed, if you try to use tbmaster.pl on a Solaris box (i.e. to control a number of your own, custom tinderbox runs[1]), the flock() call on a file descriptor that is not opened write-only fails with EBADF. [1] Thank you Dag-Erling for making tbmaster and the tinderbox scripts available. My builds for some Solaris-based stuff are so much easier using these scripts that I owe you a lot of beer :)