From owner-freebsd-current@FreeBSD.ORG  Sun Oct 15 15:22:22 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9A22C16A412;
	Sun, 15 Oct 2006 15:22:22 +0000 (UTC) (envelope-from bde@zeta.org.au)
Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0B01843D99;
	Sun, 15 Oct 2006 15:22:13 +0000 (GMT) (envelope-from bde@zeta.org.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.2.162])
	by mailout2.pacific.net.au (Postfix) with ESMTP id 44DB210B17D;
	Mon, 16 Oct 2006 01:22:01 +1000 (EST)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailproxy1.pacific.net.au (Postfix) with ESMTP id 466C58C02;
	Mon, 16 Oct 2006 01:22:00 +1000 (EST)
Date: Mon, 16 Oct 2006 01:21:59 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@delplex.bde.org
To: Cheng-Lung Sung <clsung@FreeBSD.org>
In-Reply-To: <20061015135710.A28897E98D@FreeBSD.csie.nctu.edu.tw>
Message-ID: <20061016011559.W61639@delplex.bde.org>
References: <20061015135710.A28897E98D@FreeBSD.csie.nctu.edu.tw>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Mailman-Approved-At: Sun, 15 Oct 2006 15:24:31 +0000
Cc: freebsd-current@FreeBSD.org, freebsd-hackers@FreeBSD.org,
	freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Oct 2006 15:22:22 -0000

On Sun, 15 Oct 2006, Cheng-Lung Sung wrote:

> System: FreeBSD.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Thu May 11 14:31:45 CST 2006     root@FreeBSD.csie.nctu.edu.tw:/home/usr.obj/usr/src/sys/FREEBSD  i386
>
>> Description:
> - sys/sem.h has included sys/ipc.h, which includes sys/_types.h
>  but it (and its including files) does not include sys/types.h
> - therefore, in sys/sem.h struct semid_ds declares "time_t sem_otime;" ...etc
> - if we only compile a program which do not include sys/types.h, it will fail.

Including sys/types.h would add lots of namespace pollution which
sys/ipc.h and sys/sem.h are trying hard to avoid.   sem.h is trying too
hard -- POSIX requires it to declare time_t (and pid_t, key_t and size_t,
which it already declares).

Bruce