From owner-svn-src-head@freebsd.org Thu Jul 26 17:11:15 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A748710552F6; Thu, 26 Jul 2018 17:11:15 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48AD770985; Thu, 26 Jul 2018 17:11:15 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5C33E32F; Thu, 26 Jul 2018 13:11:06 -0400 (EDT) Received: from web4 ([10.202.2.214]) by compute5.internal (MEProxy); Thu, 26 Jul 2018 13:11:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=8UsyGK j6eEFjERDo/cfdCG4IUTbhwkDh8FUNhnIdAnY=; b=Kr6FydO0c4wBj2IaOHOJ0D u52qntgbepQ/TGqrV0mrmbRytvF331EkOAbIKWH1y76GZ7X8V1Evz+XB3eu4EyPO HEIbNPyxRFELPRcovDXE+TVMP6Y19RhdJSLfqCmgIa5RWXczmIulIoOMsnwpTEIy J2YkNdEw2AfJRgxETVNzG7CSfGhnuIXOvYXS6BYZUffkBJL7qM0hgObBVHIytJr/ ihaAZbM9tsMia8/lxJFwf2clMeh9nutd4iPylkjPeQd1FxzRN2UooIfr/Plo+cfW oV8uOimvCcU2ik81lQK+1X7a0ZXhfX0da6x+9N4NVtCp8KHhYoCcVdbjca0ZfCfw == X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id AA529BA4CF; Thu, 26 Jul 2018 13:11:05 -0400 (EDT) Message-Id: <1532625065.2234037.1453936096.39AD7179@webmail.messagingengine.com> From: Brad Davis To: Shawn Webb Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-0843ff3e Date: Thu, 26 Jul 2018 11:11:05 -0600 In-Reply-To: <20180726170900.twg3qeh34wmaerul@mutt-hbsd> References: <201807261705.w6QH5Y1D034822@repo.freebsd.org> <20180726170900.twg3qeh34wmaerul@mutt-hbsd> Subject: Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 17:11:15 -0000 On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote: > On Thu, Jul 26, 2018 at 05:05:34PM +0000, Brad Davis wrote: > > Author: brd > > Date: Thu Jul 26 17:05:33 2018 > > New Revision: 336744 > > URL: https://svnweb.freebsd.org/changeset/base/336744 > > > > Log: > > Convert bsd.files.mk to support DIRS and simplify by only having one install > > target. > > > > Also update the pfctl tests Makefile to work with this change. > > > > Approved by: bapt (mentor) > > Differential Revision: https://reviews.freebsd.org/D16430 > > > > Modified: > > head/sbin/pfctl/tests/files/Makefile > > head/share/mk/bsd.files.mk > > > > Modified: head/sbin/pfctl/tests/files/Makefile > > ============================================================================== > > --- head/sbin/pfctl/tests/files/Makefile Thu Jul 26 16:51:23 2018 (r336743) > > +++ head/sbin/pfctl/tests/files/Makefile Thu Jul 26 17:05:33 2018 (r336744) > > @@ -4,9 +4,7 @@ TESTSDIR= ${TESTSBASE}/sbin/pfctl/files > > BINDIR= ${TESTSDIR} > > > > # We use ${.CURDIR} as workaround so that the glob patterns work. > > -FILES= ${.CURDIR}/pf????.in > > -FILES+= ${.CURDIR}/pf????.include > > -FILES+= ${.CURDIR}/pf????.ok > > +FILES!= echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok > > Should this use ${ECHO} instead of echo? No, that wouldn't work at all with the !=. Regards, Brad Davis