From owner-cvs-src@FreeBSD.ORG  Thu Feb  2 09:35:08 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ED3AF16A420
	for <cvs-src@freebsd.org>; Thu,  2 Feb 2006 09:35:08 +0000 (GMT)
	(envelope-from oleg@lath.rinet.ru)
Received: from lath.rinet.ru (lath.rinet.ru [195.54.192.90])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3CF3743D46
	for <cvs-src@freebsd.org>; Thu,  2 Feb 2006 09:35:08 +0000 (GMT)
	(envelope-from oleg@lath.rinet.ru)
Received: from lath.rinet.ru (localhost [127.0.0.1])
	by lath.rinet.ru (8.13.4/8.13.4) with ESMTP id k129Z6Z9024027
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 2 Feb 2006 12:35:06 +0300 (MSK)
	(envelope-from oleg@lath.rinet.ru)
Received: (from oleg@localhost)
	by lath.rinet.ru (8.13.4/8.13.4/Submit) id k129Z67h024026;
	Thu, 2 Feb 2006 12:35:06 +0300 (MSK) (envelope-from oleg)
Date: Thu, 2 Feb 2006 12:35:06 +0300
From: Oleg Bulyzhin <oleg@freebsd.org>
To: Mihail Balikov <misho@interbgc.com>
Message-ID: <20060202093506.GB21235@lath.rinet.ru>
References: <200602011441.k11Ef8Gi068735@repoman.freebsd.org>
	<004101c627d7$4960f260$08e009d9@misho>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <004101c627d7$4960f260$08e009d9@misho>
User-Agent: Mutt/1.5.11
Cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/dev/bge if_bge.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Feb 2006 09:35:09 -0000

On Thu, Feb 02, 2006 at 11:01:42AM +0200, Mihail  Balikov wrote:
> in bge_poll_locked() , when you detect link state change,
> why don't you call bge_link_upd() immediately, instead of waiting for next
> POLL_AND_CHECK ?

bge_link_upd() is rather expensive. Some versions of bcm570x chip have
semi-broken statusword - they always report link event, so you will get HZ/sec
calls of bge_link_upd() (which involves ~6 pci register reads for copper nics).

Anyway, you can tweak kern.polling.reg_frac in order to detect link events
earlier.

> 
> 
> ----- Original Message ----- 
> From: "Oleg Bulyzhin" <oleg@FreeBSD.org>
> To: <src-committers@FreeBSD.org>; <cvs-src@FreeBSD.org>;
> <cvs-all@FreeBSD.org>
> Sent: Wednesday, February 01, 2006 4:41 PM
> Subject: cvs commit: src/sys/dev/bge if_bge.c
> 
> 
> > oleg        2006-02-01 14:41:08 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/dev/bge          if_bge.c
> >   Log:
> >   Since bge_rxeof() & bge_txeof() depends on status block data it should
> be
> >   synchronized on every call of bge_poll_locked().
> >
> >   Suggested by:   Mihail Balikov <mihail.balikov AT interbgc DOT com>
> >   Approved by:    glebius (mentor)
> >   MFC after:      3 days
> >
> >   Revision  Changes    Path
> >   1.121     +16 -14    src/sys/dev/bge/if_bge.c
> > _______________________________________________
> > cvs-src@freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/cvs-src
> > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org"
> >
> >
> > __________ NOD32 1.1390 (20060201) Information __________
> >
> > This message was checked by NOD32 antivirus system.
> > http://www.eset.com
> >
> >

-- 
Oleg.