From owner-cvs-all Sat Jan 6 4:38:58 2001 From owner-cvs-all@FreeBSD.ORG Sat Jan 6 04:38:55 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id AE4AA37B400; Sat, 6 Jan 2001 04:38:53 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA24254; Sat, 6 Jan 2001 23:38:43 +1100 Date: Sat, 6 Jan 2001 23:39:35 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Alexander Langer Cc: Jeroen Ruigrok van der Werven , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/s3 Makefile In-Reply-To: <20010106125323.A2966@cichlids.cichlids.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 6 Jan 2001, Alexander Langer wrote: > Thus spake Jeroen Ruigrok van der Werven (asmodai@FreeBSD.org): > > > We don't use += for SRCS in Makefiles, we simply use the > > line continuation character and state the rest of the sourcefiles > > on the next line. > > Uhm: > alex:/sys/modules $ grep 'SRCS[^\t ]+=' */Makefile | wc -l > 38 Correcting the pattern to 'SRCS[ ]*+=' (hard tab in this) gives a count of 127. These are mostly style bugs, although not as bad as non-null whitespace between variables and assignment operators (the bad example of modules/fxp/Makefile seems to have been cloned all over). `+=' may be right for separating logically diferent parts of SRCS, e.g., generated header files from non-generated .c files. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message