From owner-svn-src-head@freebsd.org Thu Dec 5 05:14:36 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 476C81BB362; Thu, 5 Dec 2019 05:14:36 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47T3mq42Jkz3HwG; Thu, 5 Dec 2019 05:14:35 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-oi1-x243.google.com with SMTP id d62so1576838oia.11; Wed, 04 Dec 2019 21:14:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rlw7p8qkRt5wBWHEcyYEFFwmnn6ESdty/bftfJIK8BU=; b=qduouTzWDw4Mt/KqP8cTxy4SO6y0ef5wbAak56nUYnY0F6vWmbUPUi3zH5V9VmKV1F ivgYtd3HtXqPr47jeFlnaVUpUhqGw7F2u2T0rZB6cAhy3UBrF/78qTVyKGahz+SZACav JJWq2dzAbzF7LB3MRob8k0x2+m0Ytyxcb7AAu7Q0de+FHsD0vtkMn9tbyM9GHT6YEQhl ogp/CFbvpHdxFqSH1UqOA0v74FyNQ/i9qXkd3NQPi89ge/HRjDg1EQyL5N8yAYES2rbT jhkeyPgUZ7dwh23IAZ2iat2wsrWJgsZ2uReMfLll7BkjGw28fZwcb2/U81q04P7yB5HP rmmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rlw7p8qkRt5wBWHEcyYEFFwmnn6ESdty/bftfJIK8BU=; b=YEg4rdj2JlcMaQ0h8bVdCk/Q9JuKciKqCW6dPsevjxwXWewoQw2obcP/zdACBqW03W MFRt8inZBK9HiDahLtWTm442L10axssZlNRr01LpX9VbergJNBIp4hvcg9RCqmxWqOi5 r6063vidROiSVnHUSCDnczDfntVL84LQSKUzDuLdjugsRBKHYaoZfKzA4RdpcXUTsuCA nlqjwu9r9fQ83kTOVUsF8ZR8mBkkTfjIZB9lgfVqg48PGcuyHG9yV7VAe3UvwKFqQ9Zb SXytXY25McEswfIZNLOIKgqYX7x2XOhbFiqXhlLBcVBDtaQeOPM89kAFb6J1D9dkKG1p MqTA== X-Gm-Message-State: APjAAAWG3t2/P39kyoXfXkbyivha7tDHsCH0op48U+F9b81Y/iSh4Ut3 Es5j19k+cTN4yyb+fqOd4BFpOEo0 X-Google-Smtp-Source: APXvYqzhHXX5v20XVhMR7aqR8GsLm4Lzxp9nt63hMdPNJgJk7MAYh8QBEjVuR79GQaswcGTZwtMypg== X-Received: by 2002:aca:31c8:: with SMTP id x191mr5639022oix.25.1575522873122; Wed, 04 Dec 2019 21:14:33 -0800 (PST) Received: from spectre.mavhome.dp.ua ([2600:1700:3580:3560:228:f8ff:fe04:d12]) by smtp.gmail.com with ESMTPSA id r124sm3244641oie.9.2019.12.04.21.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2019 21:14:32 -0800 (PST) Sender: Alexander Motin Subject: Re: svn commit: r355412 - head/sys/geom To: Ravi Pokala , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201912050452.xB54qKV0080126@repo.freebsd.org> <516874DA-E57F-4EAA-852B-1129A95BB998@panasas.com> From: Alexander Motin Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAG0IUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raS5AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczM AAoJEIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLq A6xe6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHu uC5vgPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15Gc sS9YcQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9 TevwGsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCg lz65AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6ZAXgD tmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8FlvmI/c 40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt3ytU 8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZR1Ed EIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm59R8A EQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczMAAoJ EIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLqA6xe 6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHuuC5v gPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15GcsS9Y cQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9Tevw Gsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCglz4= Message-ID: <3e7a9cfe-46c6-73bd-3bd8-3e3c5daf52b9@FreeBSD.org> Date: Thu, 5 Dec 2019 00:14:31 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <516874DA-E57F-4EAA-852B-1129A95BB998@panasas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 47T3mq42Jkz3HwG X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qduouTzW; dmarc=none; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::243 as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-2.56 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.36)[ip: (2.42), ipnet: 2607:f8b0::/32(-2.23), asn: 15169(-1.93), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[3.4.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2019 05:14:36 -0000 Hi. On 05.12.2019 00:00, Ravi Pokala wrote: > -----Original Message----- > From: on behalf of Alexander Motin > Date: 2019-12-04, Wednesday at 20:52 > To: , , > Subject: svn commit: r355412 - head/sys/geom > > Author: mav > Date: Thu Dec 5 04:52:19 2019 > New Revision: 355412 > URL: https://svnweb.freebsd.org/changeset/base/355412 > > Log: > Wrap g_trace() into a macro to avoid unneeded calls. > > In most cases with debug disabled this function does nothing, but argument > passing and the call still cost measurable time due to cache misses, etc. > > Hi Alexander, > > I'm having trouble understanding this change, on a few levels. > > - Why did you add parentheses around the function declaration and definition? To make pre-processor not replace them also. > - How can that function with that name co-exist with a macro of the same name? The macro is handled first by pre-processor, compiler goes second on the result. > - Isn't the "g_debugflags" test in geom_dump.c:g_trace() now redundant? > - Why not simply convert geom_dump.c:g_trace() into a 'static inline' in geom.h, and not have to bother with the macro at all? One answer to both questions: compatibility with already built modules require the function to be present and behave same as before, while newly built code should be more efficient without changes. > What am I missing? > > Thanks, > > Ravi (rpokala@) > > MFC after: 2 weeks > Sponsored by: iXsystems, Inc. > > Modified: > head/sys/geom/geom.h > head/sys/geom/geom_dump.c > > Modified: head/sys/geom/geom.h > ============================================================================== > --- head/sys/geom/geom.h Thu Dec 5 04:18:22 2019 (r355411) > +++ head/sys/geom/geom.h Thu Dec 5 04:52:19 2019 (r355412) > @@ -255,11 +255,15 @@ void g_dev_physpath_changed(void); > struct g_provider *g_dev_getprovider(struct cdev *dev); > > /* geom_dump.c */ > -void g_trace(int level, const char *, ...); > +void (g_trace)(int level, const char *, ...) __printflike(2, 3); > # define G_T_TOPOLOGY 1 > # define G_T_BIO 2 > # define G_T_ACCESS 4 > - > +extern int g_debugflags; > +#define g_trace(level, fmt, ...) do { \ > + if (__predict_false(g_debugflags & (level))) \ > + (g_trace)(level, fmt, ## __VA_ARGS__); \ > +} while (0) > > /* geom_event.c */ > typedef void g_event_t(void *, int flag); > > Modified: head/sys/geom/geom_dump.c > ============================================================================== > --- head/sys/geom/geom_dump.c Thu Dec 5 04:18:22 2019 (r355411) > +++ head/sys/geom/geom_dump.c Thu Dec 5 04:52:19 2019 (r355412) > @@ -319,7 +319,7 @@ g_confxml(void *p, int flag) > } > > void > -g_trace(int level, const char *fmt, ...) > +(g_trace)(int level, const char *fmt, ...) > { > va_list ap; -- Alexander Motin