From owner-freebsd-stable Fri Aug 25 21:36:22 2000 Delivered-To: freebsd-stable@freebsd.org Received: from teapot21.domain3.bigpond.com (teapot21.domain3.bigpond.com [139.134.5.159]) by hub.freebsd.org (Postfix) with SMTP id 2850D37B42C for ; Fri, 25 Aug 2000 21:36:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by teapot21.domain3.bigpond.com (NTMail 3.02.13) with ESMTP id la953561 for ; Sat, 26 Aug 2000 14:36:53 +1000 Received: from CWIP-T-007-p-219-166.tmns.net.au ([203.54.219.166]) by mail3.bigpond.com (Claudes-Colossal-MailRouter V2.9b 5/883791); 26 Aug 2000 14:36:52 Message-ID: <39A74935.7C6EB8EF@telstra.com> Date: Sat, 26 Aug 2000 14:36:05 +1000 From: Wobbly Organization: TANTRUM X-Mailer: Mozilla 4.74 [en] (X11; U; FreeBSD 4.1-STABLE i386) X-Accept-Language: en MIME-Version: 1.0 To: freebsd-stable@FreeBSD.ORG Subject: Re: systat broken References: <20000826070542.B16988@snark.ptc.spbu.ru> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Yup, After being belted around the head by CDROM problems, buildworld now fails... cc -O -pipe -I/usr/src/usr.bin/systat/../../sys -I/usr/obj/usr/src/i386/usr/include -c /usr/src/usr.bin/systat/mbufs.c /usr/src/usr.bin/systat/mbufs.c: In function `showmbufs': /usr/src/usr.bin/systat/mbufs.c:111: structure has no member named `m_mtypes' /usr/src/usr.bin/systat/mbufs.c:112: structure has no member named `m_mtypes' /usr/src/usr.bin/systat/mbufs.c:133: structure has no member named `m_mtypes' /usr/src/usr.bin/systat/mbufs.c:134: structure has no member named `m_mtypes' *** Error code 1 Stop in /usr/src/usr.bin/systat. *** Error code 1 etc, etc. My whiney-ass opinion is as follows: I am now sitting here suffering from not one, but TWO botched comits to STABLE in a row. SLOW DOWN!!! It seems clear from these two incidents that comits to STABLE are being made WAY WAY too fast. Rosco. "Valeriy E. Ushakov" wrote: > > After this commit systat can't be compiled since it still refers to > m_mtypes. Revision 1.11 of src/usr.bin/systat/mbuf.c should be MFC'ed > as well, it seems. > > peter 2000/08/25 16:18:53 PDT > > Modified files: (Branch: RELENG_4) > sys/kern uipc_mbuf.c > sys/sys mbuf.h > usr.bin/netstat mbuf.c > Log: > MFC: kern/uipc_mbuf.c v1.53, sys/mbuf.h v1.52, netstat/mbuf.c v1.18 > Make mbstat.m_mtypes seperate and viewable via sysctl. Expand the > type from u_short to u_long to stop 64K wraparounds, especially on > mbtypes[MT_FREE]. Also, the MT_FREE counter was never incremented on > creation of new mbufs, so the freelist count was wrong. > > PR: kern/19809 > Submitted by: Ian Dowse > MFC forgotten by: albert > > Revision Changes Path > 1.51.2.2 +4 -0 src/sys/kern/uipc_mbuf.c > 1.44.2.6 +11 -9 src/sys/sys/mbuf.h > 1.17.2.1 +50 -26 src/usr.bin/netstat/mbuf.c > > SY, Uwe > -- > uwe@ptc.spbu.ru | Zu Grunde kommen > http://www.ptc.spbu.ru/~uwe/ | Ist zu Grunde gehen > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-stable" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message