From owner-freebsd-bugs@freebsd.org Mon Feb 26 13:49:04 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD72DF2611F for ; Mon, 26 Feb 2018 13:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6908C75EFB for ; Mon, 26 Feb 2018 13:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 9B31F2C169 for ; Mon, 26 Feb 2018 13:49:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w1QDn3h6022654 for ; Mon, 26 Feb 2018 13:49:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w1QDn3oX022653 for freebsd-bugs@FreeBSD.org; Mon, 26 Feb 2018 13:49:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 226218] "r"eading into an empty ed(1) buffer doesn't set modified status Date: Mon, 26 Feb 2018 13:49:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: freebsd@tim.thechases.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2018 13:49:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226218 Bug ID: 226218 Summary: "r"eading into an empty ed(1) buffer doesn't set modified status Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: freebsd@tim.thechases.com Created attachment 191017 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D191017&action= =3Dedit Remove the broken check for "addr !=3D addr_last" in /usr/src/bin/ed/main.c To reproduce: $ ed r file.txt 314 q $ Expected behavior: $ ed r file.txt 314 q ? q $ which keeps it in line with the POSIX requirement http://pubs.opengroup.org/onlinepubs/009604599/utilities/ed.html "If the buffer has changed since the last time the entire buffer was writte= n, the user shall be warned" Reading a file changes the buffer. Compare with the correct $ ed a x . q ? q $ where the buffer is changed and the "modified" flag is properly set. The solution appears to be to base "modified" purely on whether any lines w= ere read in (addr > 0), regardless of whether "addr !=3D addr_last" as performe= d by the attached patch. --=20 You are receiving this mail because: You are the assignee for the bug.=